WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#25586 closed defect (bug) (fixed)

Hook Docs: wp-admin/my-sites.php

Reported by: megane9988 Owned by: kpdesign
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch commit
Focuses: Cc:

Description

Attached patch has done for the all hooks in wp-admin/my-sites.php.

Attachments (7)

wp-sites.diff (2.0 KB) - added by megane9988 7 years ago.
patch of my-sites.php
wp-sites.2.diff (2.0 KB) - added by megane9988 7 years ago.
removed extra tab in line 70
wp-sites.3.diff (2.0 KB) - added by megane9988 7 years ago.
fixed comment spacing
wp-sites.4.diff (2.1 KB) - added by megane9988 7 years ago.
fix kpdesign comment part
wp-sites.5.diff (2.1 KB) - added by megane9988 7 years ago.
Remove extra whitespace after * on blank lines.
25586.6.diff (1.7 KB) - added by kpdesign 7 years ago.
Second pass on wp-sites.5.diff
25586.7.diff (1.9 KB) - added by kpdesign 7 years ago.
Add long description for myblogs_options filter, other minor fixes

Download all attachments as: .zip

Change History (11)

@megane9988
7 years ago

patch of my-sites.php

@megane9988
7 years ago

removed extra tab in line 70

@megane9988
7 years ago

fixed comment spacing

#1 @kpdesign
7 years ago

  • Keywords needs-patch added; has-patch removed
  • Owner set to kpdesign
  • Status changed from new to reviewing
  • Type changed from enhancement to defect (bug)

@megane9988: Thanks for the patch. :)

Just a few things:

myblogs_allblogs_options

  • "Fires after displays the selectbox for choose primary blog." should be "Fires after displaying the Choose Primary Site dropdown.".
  • Add a blank line between description and @since tag, per the standard.
  • Remove extra whitespace after opening and closing tags for that block.

myblogs_options

  • Description should be "Add settings to the Edit Site Settings screen".
  • Remove extra whitespace after * on blank lines.

myblogs_blog_actions

  • Description should be "Filter the displayed links for each site."
  • Remove extra whitespace after * on blank lines.
  • Remove extra tabs at the end of the apply_filters line.

Second instance of myblogs_options (line 80) should be //duplicate_hook instead of the full doc block.

Could you make these changes, and submit a new patch please?

@megane9988
7 years ago

fix kpdesign comment part

@megane9988
7 years ago

Remove extra whitespace after * on blank lines.

#2 @DrewAPicture
7 years ago

  • Keywords has-patch added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.8

Thanks for the updated patch.

We'll review the patch and get back to you shortly with any notes.

@kpdesign
7 years ago

Second pass on wp-sites.5.diff

@kpdesign
7 years ago

Add long description for myblogs_options filter, other minor fixes

#3 @DrewAPicture
7 years ago

  • Keywords commit added

25586.7.diff looks good. Thanks for the extra effort.

#4 @DrewAPicture
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 26284:

Inline documentation for hooks in wp-admin/my-sites.php.

Props megane9988, kpdesign.
Fixes #25586.

Note: See TracTickets for help on using tickets.