WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#25592 closed enhancement (fixed)

Twenty Fourteen: Revamp the style sheet

Reported by: iamtakashi Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

The CSS needs re-format & clean-up as per WordPress CSS Coding Standards.

Attachments (10)

25592.diff (83.3 KB) - added by iamtakashi 7 years ago.
25592.1.diff (4.1 KB) - added by iamtakashi 7 years ago.
25592.2.diff (53.6 KB) - added by iamtakashi 7 years ago.
pattern-light.svg (776 bytes) - added by iamtakashi 7 years ago.
pattern-dark.svg (761 bytes) - added by iamtakashi 7 years ago.
search-too-wide.png (62.0 KB) - added by lancewillett 7 years ago.
25592.3.diff (1.3 KB) - added by lancewillett 7 years ago.
Fix too-wide search button
25592.4.diff (923 bytes) - added by lancewillett 7 years ago.
Fix for search toggle creating scrollbar
25592.5.diff (2.1 KB) - added by lancewillett 7 years ago.
Better fix for JS focus for search toggle
25592.6.diff (2.1 KB) - added by lancewillett 7 years ago.
Match core screen-reader-text styles better

Download all attachments as: .zip

Change History (25)

@iamtakashi
7 years ago

#1 @iamtakashi
7 years ago

  • Keywords has-patch added

First pass at revamping the CSS. During this clean-up, I've decided to use Twenty Thirteen's gallery style instead of the default.

  • Re-format and clean-up CSS as per WordPress CSS coding standards
  • Use Twenty Thirteen style gallery style instead of the default style
  • Minor style bug fixes

#2 @lancewillett
7 years ago

In 25788:

Twenty Fourteen: first pass at CSS revamp, props iamtakashi. See #25592.

#3 @lancewillett
7 years ago

  • Milestone changed from Awaiting Review to 3.8

#4 @iamtakashi
7 years ago

New patch attached.

  • Improved responsive pattern for featured content.
  • Minor bug fixes

@iamtakashi
7 years ago

#5 @lancewillett
7 years ago

In 25854:

Twenty Fourteen: improved responsive styles for featured content and minor layout fixes. Props iamtakashi, see #25592.

#6 @lancewillett
7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

#7 @lancewillett
7 years ago

In 25980:

Twenty Fourteen: get rid of two last cases of clear class value. See #25592.

#8 @lancewillett
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@iamtakashi
7 years ago

#9 @iamtakashi
7 years ago

Second pass at revamping the CSS. Also each pattern graphics were updated in order to fix the pattern bug with orientation change on iPad.

#10 @lancewillett
7 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from reopened to closed

In 25998:

Twenty Fourteen: second pass at revamping the main CSS file. Update pattern graphics to fix issue with orientation changes on tablets. Props iamtakashi, fixes #25592.

#11 @lancewillett
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Noticed in testing that the Search screen-reader-text element is way too wide. We should make it styled the same as the Skip to Content element.

@lancewillett
7 years ago

Fix too-wide search button

#12 @lancewillett
7 years ago

Patch fixes the layout by removing the extra rule (the rule was introduced in r25998) for right: 0;.

Also improves usability of the button by causing the search input to have focus.

#13 @lancewillett
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 26691:

Twenty Fourteen: fix too-wide search "jump to" link and provide focus on the search input when it's used. Closes #25592.

#14 @lancewillett
7 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Found in testing with Takashi that r26691 fix can be applied by using left instead of right -- and we'll need RTL fix also.

@lancewillett
7 years ago

Fix for search toggle creating scrollbar

@lancewillett
7 years ago

Better fix for JS focus for search toggle

@lancewillett
7 years ago

Match core screen-reader-text styles better

#15 @lancewillett
7 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 26843:

Twenty Fourteen: match screen-reader-text accessibility styles a bit better with core, to avoid a jump when you move through the links, and to avoid a horizontal scroll at certain viewport widths. Also fix JS focus by specifying the first match object. Closes #25592.

Note: See TracTickets for help on using tickets.