When modifying your first menu, before saving, "Move" links do not work

[ericlewis]

Before you have saved your first menu, a draft menu is populated for you to use with all the pages on your site. If you click on the dropdown arrow to open up one of these items (assuming your site has multiple pages), there are "Move" links - 'Up one,' 'Down one,' 'Under Test page,' 'To the top'. These links don't work, at least until you save the menu.

[ankit.gade@…]

Menu move jQuery patch

[ankit.gade@…]

In wp-admin/js/nav-menu.js file the events are attached to the element on "onclick" event. So evets are attched to the element when the page gets loaded, but not to the elements which are getting added to the document dynamically. So appropriate selector should be there, So instead of adding $("#element").on('click', function(){}) it should be $('body').on('click', "#element" function(){}). By doing this change it will work for all the targeted elements which are present or getting added dynamically after the page load.

[azaozz]

Yes, delegating the click would work for all elements, initially loaded and added later. A bit better/faster way to do this would be to add one event handler and check the target:

$(document).on( 'click.move-menu', function( event ) {
  var $target = $( event.target );

  if ( $target.hasCLass('menus-move-up') ) {
    ...
  } else if ( $target.hasCLass('menus-move-down') ) {
    ...
  } else if ( ... )
});

[nacin]

In 26613:

Nav Menus: Delegate click events for move links.

props ankit.gade.
fixes #25594.

[atimmer]

[26613] introduces 3 new jshint errors, ​25594.jshint.diff fixes this.

[nacin]

Those were a mistake on my part, I had removed them to chain these, then decided against. Thanks.

[nacin]

In 26623:

Return some semicolons. fixes #25594.