WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#25596 closed defect (bug) (fixed)

Hook Docs: wp-includes/ms-blogs.php

Reported by: miyauchi's profile miyauchi Owned by: drewapicture's profile DrewAPicture
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch commit
Focuses: Cc:

Description

Attached patch has done for the all hooks in wp-includes/ms-blogs.php

Attachments (6)

ms-blogs.diff​ (7.0 KB) - added by miyauchi 11 years ago.
patch for wp-includes/ms-blogs.php
ms-blogs.2.diff​ (7.0 KB) - added by miyauchi 11 years ago.
duplicate => duplicate_hook and blog's detail => Blog's details
ms-blogs.3.diff​ (7.5 KB) - added by miyauchi 11 years ago.
fix "duplicate_hook" to "This filter is documented in ..."
25596.diff​ (7.9 KB) - added by DrewAPicture 11 years ago.
4th pass
25596.2.diff​ (8.0 KB) - added by DrewAPicture 11 years ago.
long description for blog_option_{$option} filter
25596.3.diff​ (8.0 KB) - added by kpdesign 11 years ago.
One more time. Fixes some @since values, s/integer/int

Download all attachments as: .zip

Change History (14)

@miyauchi
11 years ago

patch for wp-includes/ms-blogs.php

#1 @GaryJ
11 years ago

  • Keywords needs-patch added; has-patch removed

Duplicate hooks should be documented with //duplicate_hook and not //duplicate. See ​http://make.wordpress.org/core/handbook/inline-documentation-standards/php-documentation-standards/#4-1-duplicate-hooks

#2 @toscho
11 years ago

  • Cc info@… added

Filter the blog's detail. should be Filter the blog's details. Plural.

@miyauchi
11 years ago

duplicate => duplicate_hook and blog's detail => Blog's details

#3 @miyauchi
11 years ago

Thanks. I have added new patch.

#4 @miyauchi
11 years ago

  • Keywords has-patch added; needs-patch removed

#5 @DrewAPicture
11 years ago

  • Milestone changed from Awaiting Review to 3.8
  • Owner set to DrewAPicture
  • Status changed from new to reviewing
  • Type changed from enhancement to defect (bug)

@miyauchi
11 years ago

fix "duplicate_hook" to "This filter is documented in ..."

@DrewAPicture
11 years ago

4th pass

#6 @DrewAPicture
11 years ago

  • Keywords commit added

25596.diff​ is a fourth pass on previous patches. Shortened up some of the parameter descriptions for consistency.

@DrewAPicture
11 years ago

long description for blog_option_{$option} filter

@kpdesign
11 years ago

One more time. Fixes some @since values, s/integer/int

#7 @kpdesign
11 years ago

25596.3.diff​ fixes some @since values, integer/int for consistency with other doc blocks.

@DrewAPicture, I think this one's ready to go in.

#8 @DrewAPicture
11 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 26502:

Inline documentation for hooks in wp-includes/ms-blogs.php.

Props miyauchi, kpdesign.
Fixes #25596.

Note: See TracTickets for help on using tickets.