Opened 11 years ago
Closed 11 years ago
#25607 closed defect (bug) (fixed)
Hook Docs: /wp-admin/includes/class-wp-ms-sites-list-table.php
Reported by: | ShinichiN | Owned by: | kpdesign |
---|---|---|---|
Milestone: | 3.8 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Inline Docs | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
Added inline docs to the /wp-admin/includes/class-wp-ms-sites-list-table.php
Attachments (5)
Change History (12)
#2
@
11 years ago
- Milestone changed from Awaiting Review to 3.8
- Owner set to kpdesign
- Status changed from new to reviewing
- Type changed from enhancement to defect (bug)
#3
@
11 years ago
25607.3.diff fixes hook descriptions, adds long descriptions, and provides defaults as needed.
#4
@
11 years ago
- Keywords needs-patch added; has-patch removed
wpmu_blogs_columns
filter
- This is specific to the Multisite Network Admin, correct?
manage_sites_action_links
filter
- We should use a different doc-specific variable for
$blog['blog_id']
. I suggest$blog_id
- For the
$blogname
parameter, we don't need to dance around the types of installations ... there's only two. So maybe, "Site path, depending on whether it's a subdomain or subdirectory install"
wpmublogsaction
action:
- "Fires in the plugin column to display plugin links and information." -- remove the second "plugin"
- Use
$blog_id
instead of$blog['blog_id']
for the parameter variable
manage_sites_custom_column
action:
- "Fires for each registered custom column in the sites list table."
- Use
$blog_id
instead of$blog['blog_id']
as the parameter variable
#5
@
11 years ago
- Keywords has-patch added; needs-patch removed
Thanks for the review. I've made the recommended changes, and uploaded a new patch (25607.4.diff).
#6
@
11 years ago
- Keywords commit added
25607.4.diff looks pretty good. Was kind of fun finding out more about the wpmublogactions
hook. Updated the description(s) for that in 25607.2.diff.
Note: See
TracTickets for help on using
tickets.
Filter the blogs' columns array.
should be:Filter the blog's columns array.
Same change for
The array of the blogs' columns.
:The array of the blog's columns.
depending on the install, subdomain or subdirecotry
should be:depending on the installation: subdomain or subdirectory