WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 5 months ago

#25608 closed defect (bug) (fixed)

Hook Docs (7): wp-admin/includes/class-wp-ms-themes-list-table.php

Reported by: ShinichiN Owned by: kpdesign
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch
Focuses: docs Cc:

Description

Adding inline docs to the hooks in /wp-admin/includes/class-wp-ms-themes-list-table.php

Attachments (4)

25608.diff (4.6 KB) - added by ShinichiN 9 months ago.
25608-2.diff (4.8 KB) - added by ShinichiN 8 months ago.
Changed according to the reviews. Thank you.
25608.2.diff (5.2 KB) - added by DrewAPicture 7 months ago.
3rd pass
25608.3.diff (6.7 KB) - added by kpdesign 5 months ago.
Fourth pass

Download all attachments as: .zip

Change History (15)

ShinichiN9 months ago

comment:1 toscho9 months ago

  • Cc info@… added

Filter the action links to be displayed under each themes.

Should be singular:

Filter the action links to be displayed under each theme.


This sounds somehow … odd:

The links which user can take actions to the themes with.


What does this mean?

Filter the action links to be displayed under a certain theme themes.


For theme_action_links_$stylesheet the $stylesheet part might deserve an explanation.


In …

Fires when the row of each theme has been displayed and ended with </tr>.

… and …

Fires when the row of a certain theme has been displayed and ended with </tr>.

… the </tr> should be escaped or written without < and >, because unescaped HTML causes problems in the doc block parser.

comment:2 DrewAPicture8 months ago

  • Keywords needs-patch added; has-patch removed
  • Type changed from enhancement to defect (bug)

This still needs a new patch incorporating the changes suggested in comment:1.

comment:3 ShinichiN8 months ago

Thanks for the review.
I'll be working on this in a few days.

ShinichiN8 months ago

Changed according to the reviews. Thank you.

comment:4 ShinichiN8 months ago

  • Keywords has-patch added; needs-patch removed

comment:5 kpdesign8 months ago

  • Owner set to DrewAPicture
  • Status changed from new to reviewing

DrewAPicture7 months ago

3rd pass

comment:6 DrewAPicture7 months ago

  • Summary changed from Hook Docs: /wp-admin/includes/class-wp-ms-themes-list-table.php to Hook Docs (7): /wp-admin/includes/class-wp-ms-themes-list-table.php

25608.2.diff tightens up short descriptions and promotes consistency in individualizing hooks from each other.

comment:7 DrewAPicture6 months ago

  • Milestone changed from Awaiting Review to 3.9

comment:8 DrewAPicture6 months ago

  • Owner changed from DrewAPicture to kpdesign

25608.2.diff looks good to me.

comment:9 jeremyfelt6 months ago

  • Component changed from Inline Docs to Themes
  • Focuses docs added

kpdesign5 months ago

Fourth pass

comment:10 kpdesign5 months ago

  • Summary changed from Hook Docs (7): /wp-admin/includes/class-wp-ms-themes-list-table.php to Hook Docs (7): wp-admin/includes/class-wp-ms-themes-list-table.php

25608.3.diff expands on descriptions for a couple filters, and some minor changes for consistency. It also contains the documentation for both hooks in wp-admin/includes/class-wp-themes-list-table.php, which are duplicates of hooks in wp-admin/includes/class-wp-ms-themes-list-table.php.

I think this one's ready to go in.

comment:11 DrewAPicture5 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 27090:

Inline documentation for hooks in wp-admin/includes/class-wp-ms-themes-list-table.php.

Also marks two hooks in wp-admin/includes/class-wp-themes-list-table.php as duplicates.

Props ShinichiN, kpdesign, DrewAPicture.
Fixes #25608.

Note: See TracTickets for help on using tickets.