Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#25612 closed defect (bug) (fixed)

Hook Docs: wp-admin/includes/class-wp-ms-users-list-table.php

Reported by: shinichin's profile ShinichiN Owned by: kpdesign's profile kpdesign
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch commit
Focuses: Cc:


Adding inline doc to all the hooks in wp-admin/includes/class-wp-ms-users-list-table.php

Attachments (5)

25612.diff (2.4 KB) - added by ShinichiN 11 years ago.
25612.1.diff (2.2 KB) - added by ericlewis 11 years ago.
25612.2.diff (2.3 KB) - added by ShinichiN 11 years ago.
Changed according to the reviews. Thank you.
25612.3.diff (2.6 KB) - added by kpdesign 11 years ago.
Second pass on 25612.2.diff
25612.4.diff (2.7 KB) - added by DrewAPicture 11 years ago.

Download all attachments as: .zip

Change History (12)

11 years ago

11 years ago

#1 @ericlewis
11 years ago


  • cleans up language in some of the descriptions

with the help of @rzen

Last edited 11 years ago by ericlewis (previous) (diff)

#2 @DrewAPicture
11 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from Awaiting Review to 3.8
  • Type changed from enhancement to defect (bug)

Thanks for the work folks. Remaining notes on 25612.1.diff:

  • s/multisite/Multisite

ms_user_row_actions filter:

  • The second parameter should have a type of WP_User

manage_users_custom_column filter:

  • Update the duplcate hook comment to the new style:
    /** This filter is documented in wp-admin/includes/class-wp-users-list-table.php */

#3 @ShinichiN
11 years ago

Thank you ericlewis for the clean up!


The second parameter should have a type of WP_User

do you mean that it should be like following?

* @param WP_User $user WP_User object.

11 years ago

Changed according to the reviews. Thank you.

#4 @kpdesign
11 years ago

  • Owner set to kpdesign
  • Status changed from new to reviewing

11 years ago

Second pass on 25612.2.diff

#5 @kpdesign
11 years ago

25612.3.diff contains doc block fixes for consistency with similar blocks, adds defaults.

11 years ago


#6 @DrewAPicture
11 years ago

  • Keywords has-patch commit added; needs-patch removed

25612.4.diff should do it.

#7 @DrewAPicture
11 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 26342:

Inline documentation for hooks in wp-admin/includes/class-wp-ms-users-list-table.php.

Props ShinichiN, kpdesign.
Fixes #25612.

Note: See TracTickets for help on using tickets.