Make WordPress Core

Opened 11 years ago

Closed 10 years ago

Last modified 10 years ago

#25614 closed defect (bug) (fixed)

Make sure we translate the error messages in _doing_it_wrong() calls

Reported by: georgestephanis's profile georgestephanis Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.1 Priority: normal
Severity: normal Version:
Component: I18N Keywords:
Focuses: Cc:


Found two places in core where we weren't translating it. Patch attached.

Attachments (1)

translate_doing_it_wrong.diff (1.1 KB) - added by georgestephanis 11 years ago.

Download all attachments as: .zip

Change History (6)

#1 @johnbillion
11 years ago

  • Component changed from General to I18N
  • Milestone changed from Awaiting Review to 3.7

#2 @nacin
11 years ago

  • Milestone changed from 3.7 to Awaiting Review

The DB one could be run before the translation functions are loaded. As in, fatal errors. Needs testing. The other is fine but (as I also communicated in IRC before this ticket was moved to 3.7) I didn't want to add yet another string to 3.7 so late, especially for such an edge case.

#3 @SergeyBiryukov
10 years ago

  • Milestone changed from Awaiting Review to 4.1
  • Owner set to SergeyBiryukov
  • Status changed from new to accepted

#4 @SergeyBiryukov
10 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 29840:

Translate some previously untranslated _doing_it_wrong() messages.

props georgestephanis.
fixes #25614.

#5 @nacin
10 years ago

[29840] is fine in wpdb but note wp_load_translations_early() should possibly be called here.

Note: See TracTickets for help on using tickets.