Opened 11 years ago
Closed 11 years ago
#25621 closed defect (bug) (fixed)
Hook Docs (27): wp-includes/post-template.php
Reported by: | Toru | Owned by: | DrewAPicture |
---|---|---|---|
Milestone: | 3.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Posts, Post Types | Keywords: | has-patch commit |
Focuses: | docs, template | Cc: |
Description
Attached patch has done for all hooks in wp-includes/post-template.php
Attachments (4)
Change History (13)
#2
@
11 years ago
- Keywords needs-patch added; has-patch removed
- Owner set to DrewAPicture
- Status changed from new to reviewing
- Type changed from enhancement to defect (bug)
This still needs a new patch incorporating the changes suggested in comment:1.
#3
@
11 years ago
Thank you very much ericlewis and DrewAPicture for the review. Took a time, but attached the 2nd patch at last.
#4
@
11 years ago
- Keywords has-patch added; needs-patch removed
- Summary changed from Hook Docs: wp-includes/post-template.php to Hook Docs (27): wp-includes/post-template.php
#7
@
11 years ago
25621.3.diff contains fixes for language, formatting, and @since values.
This needs a secondary review and a recommendation.
#8
@
11 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 3.9
25621.diff should take care of it.
Note: See
TracTickets for help on using
tickets.
Hi Toru,
thanks for the initial patch! Here are some comments:
@param string $more_link_text Link text of the Read More link.
is a bit verbose. How about@param string $more_link_text Read More link element.
Filter the retrieved post excerpt
can beFilter the post excerpt
Filter the returned CSS classes for the current post
can beFilter the CSS classes for the current post
@param string $post->guid Global Unique Identifier (guid) of the post
should be@param string $post_guid Global Unique Identifier (guid) of the post
. This comes up a few times in your patch, so change them all please. Referencing class properties in PHPDoc is an issue, and we're going to be using pseudo-variables in the docblock where this happens.@param int $post->ID The post ID.
should be@param int $post->ID Post ID.
Filter wp_list_pages.
is too brief for a short description.Filters CSS classes applied to each list items of page list created by wp_list_pages().
is rough. Can you revisit and try to smooth that out?Filters a retrieved attachment page link
needs a period on the end.Filters HTML output of attachment link with medium sized representation, wrapped with <p class="attachment"> attribute.
is a bit verbose as well. Although the detail is a good thought, something more generic would suffice.Filter attachment markup to be prepended to post content.
, and then in the long description give more technical description,Thanks again, looking forward to the next patch.