WordPress.org
Get WordPress

Make WordPress Core

Opened 11 years ago

Closed 11 years ago

#25631 closed enhancement (fixed)

Fix strict notices in POMO library

Reported by: markoheijnen's profile markoheijnen Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

Added an update to some of the POMO files to fix strict notices. Fixes the suppression of strict notices in the unit tests added in [25395].

Attachments (2)

pomo.diff​ (10.4 KB) - added by markoheijnen 11 years ago.
25631.patch​ (6.6 KB) - added by SergeyBiryukov 11 years ago.

Download all attachments as: .zip

Change History (4)

@markoheijnen
11 years ago

@SergeyBiryukov
11 years ago

#1 @SergeyBiryukov
11 years ago

The set_headers() changes are not necessary after [23357].

I think we should just create PO instances, like we do in Tests_POMO_MO​, instead of calling the methods statically. See 25631.patch​.

#2 @SergeyBiryukov
11 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26500:

Fix strict notices in Tests_POMO_PO.

props markoheijnen for initial patch.
fixes #25631.

Note: See TracTickets for help on using tickets.