Opened 12 years ago
Closed 11 years ago
#25638 closed defect (bug) (fixed)
Hook Docs (25): wp-includes/default-widgets.php
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 3.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Widgets | Keywords: | has-patch commit |
Focuses: | docs | Cc: |
Description
Add hook documentation to wp-includes/default-widgets.php
Attachments (6)
Change History (16)
#3
@
12 years ago
New Diff replaced
//duplicate_hook
to :
/** This action|filter is documented in /wp-includes/default-widgets.php (this file) */
Since all duplicates are the widget_title hook, which is defined in the same file.
#4
@
12 years ago
/** This action|filter is documented in /wp-includes/default-widgets.php (this file) */
FWIW, based on http://make.wordpress.org/core/handbook/inline-documentation-standards/php-documentation-standards/#4-1-duplicate-hooks
- you should also change
action|filter
toaction
orfilter
depending on if it's anapply_filters()
/do_action()
hook you're documenting - file path shouldn't begin with /
- suffixing (this file) isn't needed, as it's primarily going to be used for automated parsing into the new documentation site when launched.
Based on http://make.wordpress.org/core/handbook/inline-documentation-standards/php-documentation-standards/#5-2-multi-line-comments you'll also want to wrap the descriptions in some of the longer blocks (such as for the widget_archives_dropdown_args
filter)
Not intended to be a full review, just pointing out the few small things that I noticed.
#5
@
11 years ago
- Keywords needs-patch added; has-patch removed
- Summary changed from Hooks Docs: wp-includes/default-widgets.php to Hook Docs (25): wp-includes/default-widgets.php
See comment:4
#8
@
11 years ago
- Owner changed from kpdesign to DrewAPicture
25638.4.diff contains formatting and language changes.
This needs a secondary review and a recommendation.
#9
@
11 years ago
- Keywords commit added
- Milestone changed from Awaiting Review to 3.9
25638.3.diff should cover it.
the documantation