mysql2date() preg_replace() misinterpretation

[tenpura]

preg_replace() in mysql2date() is using "
1" as backreference and if this is immediately followed by a literal number, misinterpretation occurs.

Suggested Solution:
use "\${1}" instead of "
1"

[markjaquith]

+1 This suggestion follows the guidelines set out at ​http://php.net/preg_replace for backreferences that may be followed by literal numbers.

[ryan]

Duplicate of #2521.

[tenpura]

Yes, date_i18n() part of that has already been fixed but mysql2date() part remains the same using "
1".
This is the same type of problem as ticket #2521 but regarding different section and unsolved.

[tenpura]

I see... it seems like this problem was supposed to be fixed at ticket #2521 but somehow accidentally resolved partially (only date_i18n part was fixed) and closed.
Should I close my ticket and reopen ticket #2521 instead to take care of this issue?

[ryan]

Ah, I see. We can fix it in this ticket. Leave it open.

[ryan]

(In [3654]) Fix backreferences in mysql2date(). Props tenpura. fixes #2564

[ryan]

Reopen for inclusion in 2.0.3.

[ryan]

(In [3745]) Fix backreferences in mysql2date(). Props tenpura. fixes #2564

[dustball]

(PHP 4.2.2. MySQL 3.23.51)

On a vanilla install of 2.0.3, the date shows up as: "{1}June 7th, 2006".

Once I reverted this fix in my local install, the date correctly showed as "June 7th, 2006".

[ryan]

See #2774.

[foolswisdom]

Closing FIXED, based on Ryan's update to see #2774.

[(none)]

Milestone 2.0.3 deleted