moderation.php needs paging

[fimion]

In wp-admin/moderation.php on line 123,

$comments = $wpdb->get_results("SELECT * FROM $wpdb->comments WHERE comment_approved = '0'");

can cause php to hit it's internal memory limit if there are too many comments in moderation (generally caused by spam). To remedy this, I suggest you add a limit to the number of results returned.

so something like

$comments = $wpdb->get_results("SELECT * FROM $wpdb->comments WHERE comment_approved = '0' ORDER BY `comment_date` ASC LIMIT 0 , 100");

This will sort oldest to newest and only return 100.

This was brought up due to a case of a blog with 2000+ spam comments in moderation, and the guy couldn't moderate them.

[davidhouse]

I hardly think it's worthy of major severity if it only hits when you've got 2000 spam comments. That's a minority target audience if I ever did see one.

[davidhouse]

Hmmm... paging would fix this, right? I think some generalised paging code that we could apply to here and other places in the admin that need it would be nice to see.

[fimion]

yes paging code would also fix this. The above is just a dirty hack for a blog that had become a victim of massive amounts of spam.

[markjaquith]

Might be a good candidate for paging, using the helper function introduced here: #3159

[rob1n]

I think this is worth taking another look at for 2.3. #4212 was reported with the same problem, again.

[rob1n]

#4214 even.

[rob1n]

Fixed in [5574].