WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#25664 closed defect (bug) (fixed)

Behavior of the 'posts_search' filter has changed

Reported by: SergeyBiryukov Owned by: nacin
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.7
Component: Query Keywords: has-patch
Focuses: Cc:

Description

As reported on the forums, [25632] changed the behaviour of the posts_search filter.

In 3.6, the filter is applied unconditionally, even when the 's' query var is empty.

In 3.7-RC1, the filter has been moved into WP_Query::parse_search(), which is only executed if $q['s'] is not empty, so a plugin cannot add a search clause to a query if it doesn't have one.

Attachments (1)

25664.patch (1.1 KB) - added by SergeyBiryukov 5 years ago.

Download all attachments as: .zip

Change History (4)

#1 @SergeyBiryukov
5 years ago

25664.patch restores the 3.6 behaviour.

#2 @nacin
5 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25867:

Always apply the posts_search filter. Restores 3.6 behavior.

props SergeyBiryukov.
fixes #25664.

#3 @SergeyBiryukov
5 years ago

  • Version changed from trunk to 3.7
Note: See TracTickets for help on using tickets.