Make WordPress Core

Opened 12 years ago

Closed 12 years ago

Last modified 12 years ago

#25677 closed defect (bug) (fixed)

Avoid notice with search feed without orderby

Reported by: nacin's profile nacin Owned by: nacin's profile nacin
Milestone: 3.7 Priority: normal
Severity: normal Version:
Component: Query Keywords: has-patch commit
Focuses: Cc:

Description

A conditional assumes that 'orderby' is set as a query variable, but that's only fair to assume when we're not looking at feeds. Turns out it isn't a query variable that is filled, so we'll need to add an isset check.

This would be minor but a displayed notice could screw up feed parsing.

Attachments (1)

25677.diff (731 bytes) - added by nacin 12 years ago.

Download all attachments as: .zip

Change History (5)

@nacin
12 years ago

#1 @nacin
12 years ago

  • Keywords has-patch commit added

#2 @azaozz
12 years ago

Works as expected, +1.

Last edited 12 years ago by azaozz (previous) (diff)

#3 @nacin
12 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25889:

Avoid notice with search feeds.

fixes #25677.

#4 @nacin
12 years ago

In 25890:

Avoid notice with search feeds.

Merges [25889] to the 3.7 branch.

fixes #25677.

Note: See TracTickets for help on using tickets.