Automatic Update Email Error

[markmcwilliams]

FYI, absolutely loving the automatic updates, and emails saying it's been done! :)

The latest email I received though, has a little error in it, saying that WordPress 3.8.1 was available (see the attached image which may help better explain). I wondered if I'd missed something, lol!

If I can find the problem, I'll get a patch submitted if nobody does it quicker than me!

[markmcwilliams]

Looking back, I can see the reference to 3.8.1 was introduced in [25873]. I feel this should be a variable, but I'm unsure if one exists or not? To me, looking at the email, it's just confusing, especially someone who could be new to WordPress.

[markoheijnen]

Seems that only = '3.8.1' need to be removed.

[markmcwilliams]

Replying to markoheijnen:

Seems that only = '3.8.1' need to be removed.

I don't think it's that simple; however, I have attached a patch reflecting your suggestion.

Unfortunately though, I'm unsure how to test this feature (perhaps I've missed a blog post explaining this), and if it's possible to force an email when a background update is made, so please forgive me!

[nacin]

Both of those lines are test code. See 25678.2.diff​.

[markmcwilliams]

Replying to nacin:

Both of those lines are test code. See 25678.2.diff​.

Well that answers that then! :)

[dd32]

Both of those lines are test code. See 25678.2.diff​.

Looks good to me

[nacin]

In 25891:

Remove debug code from WP_Automatic_Updater::send_email().

props markmcwilliams for initial patch.
see #25678.

[nacin]

In 25892:

Remove debug code from WP_Automatic_Updater::send_email().

Merges [25891] to the 3.7 branch.

props markmcwilliams for initial patch.
fixes #25678.