WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#25678 closed defect (bug) (fixed)

Automatic Update Email Error

Reported by: markmcwilliams Owned by: nacin
Milestone: 3.7 Priority: normal
Severity: normal Version: 3.7
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:

Description

FYI, absolutely loving the automatic updates, and emails saying it's been done! :)

The latest email I received though, has a little error in it, saying that WordPress 3.8.1 was available (see the attached image which may help better explain). I wondered if I'd missed something, lol!

If I can find the problem, I'll get a patch submitted if nobody does it quicker than me!

Attachments (3)

automatic-update-error.png (99.6 KB) - added by markmcwilliams 6 years ago.
25678.diff (702 bytes) - added by markmcwilliams 6 years ago.
25678.2.diff (682 bytes) - added by nacin 6 years ago.

Download all attachments as: .zip

Change History (12)

#1 @markmcwilliams
6 years ago

Looking back, I can see the reference to 3.8.1 was introduced in [25873]. I feel this should be a variable, but I'm unsure if one exists or not? To me, looking at the email, it's just confusing, especially someone who could be new to WordPress.

#2 follow-up: @markoheijnen
6 years ago

  • Milestone changed from Awaiting Review to 3.7

Seems that only = '3.8.1' need to be removed.

@markmcwilliams
6 years ago

#3 in reply to: ↑ 2 @markmcwilliams
6 years ago

Replying to markoheijnen:

Seems that only = '3.8.1' need to be removed.

I don't think it's that simple; however, I have attached a patch reflecting your suggestion.

Unfortunately though, I'm unsure how to test this feature (perhaps I've missed a blog post explaining this), and if it's possible to force an email when a background update is made, so please forgive me!

@nacin
6 years ago

#4 follow-up: @nacin
6 years ago

  • Keywords has-patch commit added

Both of those lines are test code. See 25678.2.diff.

#5 in reply to: ↑ 4 @markmcwilliams
6 years ago

Replying to nacin:

Both of those lines are test code. See 25678.2.diff.

Well that answers that then! :)

#6 @dd32
6 years ago

Both of those lines are test code. See 25678.2.diff​.

Looks good to me

#7 @nacin
6 years ago

In 25891:

Remove debug code from WP_Automatic_Updater::send_email().

props markmcwilliams for initial patch.
see #25678.

#8 @nacin
6 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 25892:

Remove debug code from WP_Automatic_Updater::send_email().

Merges [25891] to the 3.7 branch.

props markmcwilliams for initial patch.
fixes #25678.

#9 @SergeyBiryukov
6 years ago

  • Version changed from trunk to 3.7
Note: See TracTickets for help on using tickets.