Translate meridiem in time

[Sewar]

This patches Translate meridiem in time.

I don't know if meridiem is good word for this thing, I just copied it from ​PHP's manual: date() function.

[abhay]

looks good to me.
+1

[davidhouse]

We could really do with wrapping all these localisation globals up into one associative array or class global. So e.g. instead of doing

global $meridiem, $weekday;
...
$meridiem
...
$weekday

we'd do

$global $wp_i10n;
...
$wp_i10n->meridiem
...
$wp_i10n->weekday

[Sewar]

patch for WP_Locale class

[Sewar]

davidhouse: Good idea, i've create new patch.

Please test the new patch especially functions in "wp-includes/template-functions-general.php" because i haven't test most of them.

[davidhouse]

Wow, great job. I'll check it out. People should test this because I'm an english speaker and so am not too great at checking that localisation functions work :)

[Sewar]

match changes in [3654] and fix some errors in admin files.

[Sewar]

davidhouse: I hope someone post it to wp-hackers and/or wp-polyglots mail lists.

wp_locale.3654.diff is updated version to match changes in [3654] and fix some errors in admin files.

[abhay]

Your patch looks great except for the fact that you removed the legacy variables. Put them back in and I think we're good to go.

Great job.

[Sewar]

Oops, I forget add admin-functions.php to patch, it contain patch for edit timestamp in post/page editing.

[Sewar]

Isn't it is ready for commit?

[abhay]

Provide support for legacy and it is ready.

[Sewar]

abhay: Sorry, i wasn't understand your first comment, i put them back.

[abhay]

Looks great

+1 to commit.

[ryan]

We could take it a step further and replace this:

$wp_locale->month[zeroise($arc_month, 2)]

with this:

$wp_locale->get_month($arc_month);

get_month() should handle doing the zeroise and fetching from the month array. Similarly for the rest of the locale data.

[Sewar]

ryan: Good idea, test the new patch and if it's ready commit it.

[ryan]

(In [3676]) WP_Locale. Props Sewar. fixes #2568