WordPress.org
Get WordPress

Make WordPress Core

Opened 12 years ago

Closed 5 years ago

#25691 closed defect (bug) (wontfix)

Refactor StringExtractor

Reported by: nbachiyski's profile nbachiyski Owned by: nbachiyski's profile nbachiyski
Milestone: Priority: normal
Severity: normal Version: 3.8
Component: Build/Test Tools Keywords: needs-patch needs-unit-tests
Focuses: Cc:

Description

There are two huge and very logic-heavy methods: find_function_calls and entry_from_call. We must break them in smaller ones and make them more digestible.

Change History (7)

#1 @nbachiyski
12 years ago

  • Owner set to nbachiyski
  • Status changed from new to assigned

#2 @nbachiyski
12 years ago

In 25918:

Extract: add default rules

Two purposes:

  • Helps people, reading the code to have a better idea of the structure of the array
  • Reciprocity with $comment_prefix, which has a default value

See #25691

#3 @chriscct7
10 years ago

  • Keywords needs-unit-tests added

This ticket was mentioned in ​Slack in #core-i18n by ocean90. ​View the logs.
10 years ago

#5 @ocean90
10 years ago

  • Component changed from I18N to Build/Test Tools

#6 @ocean90
10 years ago

  • Milestone changed from Awaiting Review to Future Release

#7 @desrosj
5 years ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from assigned to closed

The tools/i18n folder was removed in [45686], so I don't think this ticket is still relevant. Going to close out, but please reopen if I am misunderstanding that.

Note: See TracTickets for help on using tickets.