WordPress.org

Make WordPress Core

Opened 5 years ago

Last modified 2 years ago

#25691 assigned defect (bug)

Refactor StringExtractor

Reported by: nbachiyski Owned by: nbachiyski
Milestone: Future Release Priority: normal
Severity: normal Version: 3.8
Component: Build/Test Tools Keywords: needs-patch needs-unit-tests
Focuses: Cc:

Description

There are two huge and very logic-heavy methods: find_function_calls and entry_from_call. We must break them in smaller ones and make them more digestible.

Change History (6)

#1 @nbachiyski
5 years ago

  • Owner set to nbachiyski
  • Status changed from new to assigned

#2 @nbachiyski
5 years ago

In 25918:

Extract: add default rules

Two purposes:

  • Helps people, reading the code to have a better idea of the structure of the array
  • Reciprocity with $comment_prefix, which has a default value

See #25691

#3 @chriscct7
3 years ago

  • Keywords needs-unit-tests added

This ticket was mentioned in Slack in #core-i18n by ocean90. View the logs.


2 years ago

#5 @ocean90
2 years ago

  • Component changed from I18N to Build/Test Tools

#6 @ocean90
2 years ago

  • Milestone changed from Awaiting Review to Future Release
Note: See TracTickets for help on using tickets.