WordPress.org

Make WordPress Core

Opened 6 months ago

Last modified 6 months ago

#25691 assigned defect (bug)

Refactor StringExtractor

Reported by: nbachiyski Owned by: nbachiyski
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 3.8
Component: I18N Keywords: needs-patch
Focuses: Cc:

Description

There are two huge and very logic-heavy methods: find_function_calls and entry_from_call. We must break them in smaller ones and make them more digestible.

Change History (2)

comment:1 nbachiyski6 months ago

  • Owner set to nbachiyski
  • Status changed from new to assigned

comment:2 nbachiyski6 months ago

In 25918:

Extract: add default rules

Two purposes:

  • Helps people, reading the code to have a better idea of the structure of the array
  • Reciprocity with $comment_prefix, which has a default value

See #25691

Note: See TracTickets for help on using tickets.