WordPress.org
Get WordPress

Make WordPress Core

Opened 19 years ago

Closed 19 years ago

Last modified 19 years ago

#2570 closed defect (bug) (fixed)

Comments feed problem in current 2.1-alpha1 (revision 3643)

Reported by: tinyau's profile tinyau Owned by: davidhouse's profile davidhouse
Milestone: 2.1 Priority: normal
Severity: major Version: 2.1
Component: General Keywords: bg|has-patch bg|tested bg|commit
Focuses: Cc:

Description

I found there are 2 problems of comments feed in the current revision 3643.

  1. "All Comments" feed generated the same content as Posts feed.
  2. Comments feed of individual posts cannnot show the comments of the posts.

Attachments (2)

2570.diff​ (422 bytes) - added by davidhouse 19 years ago.
2570.2.diff​ (2.3 KB) - added by davidhouse 19 years ago.

Download all attachments as: .zip

Change History (11)

#1 @davidhouse
19 years ago

  • Owner changed from anonymous to davidhouse
  • Status changed from new to assigned

@davidhouse
19 years ago

#2 @davidhouse
19 years ago

  • Keywords bg|has-patch added

Try that.

#3 @davidhouse
19 years ago

Err, never mind, that patch is completely broken. Working on a second.

#4 @davidhouse
19 years ago

Try this second one.

@davidhouse
19 years ago

#5 @skippy
19 years ago

  • Keywords bg|tested bg|commit added

second patch fixes the problem described in the ticket.

#6 @ryan
19 years ago

We also need to add $id and $comment to the list of globals in load_template() for back compat.

#7 @ryan
19 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

(In [3644]) Comment feed fixes from David House. fixes #2570

#8 @davidhouse
19 years ago

Perhaps we could just do the old trick of extract($GLOBALS); to give anything loaded by load_template() global scope.

#9 @ryan
19 years ago

Sounds good.

Note: See TracTickets for help on using tickets.