WordPress.org

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#25702 closed enhancement (fixed)

Make Twenty Fourteen 3.8's Default Theme

Reported by: markmcwilliams Owned by: SergeyBiryukov
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Themes Keywords: has-patch
Focuses: Cc:

Description

Seeing as 3.7 has been released, now's the chance to get Twenty Fourteen in nightly builds, etc!

Attachments (2)

25702.diff (1.2 KB) - added by markmcwilliams 5 years ago.
25702.2.diff (3.9 KB) - added by markmcwilliams 5 years ago.

Download all attachments as: .zip

Change History (9)

@markmcwilliams
5 years ago

#1 @lancewillett
5 years ago

  • Component changed from Bundled Theme to Themes
  • Milestone changed from Awaiting Review to 3.8

#2 @lancewillett
5 years ago

Yes, please! We're getting more and more requests from people who want to test and contribute to the theme, like http://make.wordpress.org/core/2013/10/31/twenty-fourteen-project-update-3/#comment-11102

#3 follow-up: @SergeyBiryukov
5 years ago

sidebars_widgets option in wp-admin/includes/upgrade.php probably needs to be updated to restore the third sidebar removed in [23529]. Related: ticket:23573:5.

#4 in reply to: ↑ 3 @markmcwilliams
5 years ago

Replying to SergeyBiryukov:

sidebars_widgets option in wp-admin/includes/upgrade.php probably needs to be updated to restore the third sidebar removed in [23529]. Related: ticket:23573:5.

Fair enough, done and done! :) See the latest patch!

#5 follow-up: @markmcwilliams
5 years ago

Seeing as 3.8 will probably be branched like 3.7 was, can we please include this currently, then if Twenty Fourteen doesn't make it into 3.8, when the theme files are removed from the 3.8 branch, you can just remove this code also?

There's a lot of people, like @lancewillett says, who want to try it out on their nightly builds!

Just a potential thought ...

#6 in reply to: ↑ 5 @SergeyBiryukov
5 years ago

Replying to markmcwilliams:

Seeing as 3.8 will probably be branched like 3.7 was, can we please include this currently, then if Twenty Fourteen doesn't make it into 3.8, when the theme files are removed from the 3.8 branch, you can just remove this code also?

That was the consensus at the 3.8 IRC meeting, so I guess we can.

#7 @SergeyBiryukov
5 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26024:

Make Twenty Fourteen the default theme. props markmcwilliams. fixes #25702.

Note: See TracTickets for help on using tickets.