update_option regression in 3.7

[calin]

The update_option action in 3.7 is triggered after the option was saved to the DB not before as stated in the documentation or as the behavior was prior to 3.7.

[bpetty]

You're right, this hook should have been moved at the same time the DB query was in r25664, and is a regression from 3.6.

See #25015.

[ocean90]

delete_option and add_option are both before the db query, so update_option should be there too.

calin, how did you noticed this, any plugin which is broken now? Would be nice to know.

[calin]

Not any specific plugin.
I was looking over the code looking for a way to check options before they are commited to the DB.

[nacin]

In 25925:

In update_option(), call the update_option hook before the DB update.

Reverses a regression from [25664].

props calin.
fixes #25705 for trunk.

[nacin]

In 25926:

In update_option(), call the update_option hook before the DB update.

Merges [25925] to the 3.7 branch.

Reverses a regression from [25664].

props calin.
fixes #25705.