in_category() returns true if the first parameter is empty

[n.uddin.w]

in wp 3.7, in_category function returns true if the first parameter ($category) is an empty array or null.

in_category( $category, $_post )

[ocean90]

Could reproduce this.

3.6:
var_dump( in_category( '', 1177) ); // bool(false)

3.7:
var_dump( in_category( '', 1177) ); // bool(true)

[ocean90]

This belongs to [25119]. There was an empty() check which is gone now.

has_tag() returns also true, but in 3.6 too. Should we add the empty() check to has_term() directly?

[nacin]

has_tag() returns also true, but in 3.6 too.

Let's reduce the regression here and not cause any others. Did it return false at any point previously?

[ericlewis]

Replying to nacin:

Did has_tag() return false at any point previously?

No, it hasn't since its inception in 3.1. The long description of the has_term() is spot on here - "If no terms are given, determines if post has any terms." since it uses is_object_in_term(), which has that logic built into it. And since every category always has at least one term, that's why we're seeing the true return in the OP's example.

Let's add the empty( $category ) check back into in_category() to fix the regression, and leave has_tag() as-is.

[SergeyBiryukov]

Related: [16478]

[ericlewis]

attachment:25706.diff​

• brings back the empty() check in in_category()
• adds a test for passing falsy values to in_category() which should return false, as well as testing for a positive result.

[nacin]

In 25923:

3.7 regression from [25119]: Have in_category() return false when the first argument is empty.

Adds unit tests.

props ericlewis.
fixes #25706 for trunk.

[nacin]

In 25924:

3.7 regression from [25119]: Have in_category() return false when the first argument is empty.

Merges [25923] to the 3.7 branch.

props ericlewis.
fixes #25706.