Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #25711, comment 4


Ignore:
Timestamp:
02/13/2014 12:19:14 AM (11 years ago)
Author:
bpetty
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #25711, comment 4

    initial v1  
    2222I've only see this fail on PHP 5.2, however, what I'd like to specifically point out is that this is comparing the result fetched from the factory, which should contain row IDs, and likely a bunch more data that is both irrelevant to this test, and is also volatile (can easily change between runs just like the ID does depending on previous tests run - try running full tests compared to just --group taxonomy).
    2323
    24 This really needs to be rewritten with more more specific values used for assertion checks. Try to avoid using arrays, they can frequently fail when just out of order (but still remain functional and correct).
     24This really needs to be rewritten with more more specific values used for assertion checks. Try to avoid using arrays, they can frequently fail when just out of order (but still remain functional and correct). In fact, don't even use the variable returned from the factory. Use an entirely explicit static array. We still need to know *exactly* what the test should be returning in case the test is failing (like it is here).