Make WordPress Core

Opened 10 years ago

Closed 10 years ago

#25718 closed enhancement (fixed)

Twenty Fourteen: Clean up post thumbnail namings

Reported by: iamtakashi's profile iamtakashi Owned by: lancewillett's profile lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:


Currently post thumbnail related stuff in the theme files has some inconsistencies such as image sizes named featured thumbnail-xxxand CSS classes like featured-thumbnail, has-featured-image, and so on. I'm going to rename all these with post-thumbnail-xxx for the sake of consistency.

Although I'm going to leave the screen reader text "No featured image" in twentyfourteen_post_thumbnail() as it is because that's a user facing text.

Also I'm going to remove the image size featured-thumbnail-formatted because the maximum width the thumbnail can be is 672px.

Attachments (1)

25718.diff (11.9 KB) - added by iamtakashi 10 years ago.

Download all attachments as: .zip

Change History (4)

10 years ago

#1 @iamtakashi
10 years ago

  • Keywords has-patch added

#2 @lancewillett
10 years ago

  • Milestone changed from Awaiting Review to 3.8

#3 @lancewillett
10 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 25971:

Twenty Fourteen: clean up post thumbnail naming. Props iamtakashi, fixes #25718.

Note: See TracTickets for help on using tickets.