WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#25719 closed defect (bug) (duplicate)

Fixed a bug with undefined 'public_query_vars' variable

Reported by: mauryaratan Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.8
Component: Query Keywords: has-patch
Focuses: Cc:
PR Number:

Description

When enabled the debug mode latest commit, received an undefined variable notice in wp-includes/class-wp.php

Attaching the patch.

Attachments (1)

class-wp.patch (707 bytes) - added by mauryaratan 6 years ago.

Download all attachments as: .zip

Change History (9)

#1 @c3mdigital
6 years ago

  • Resolution set to duplicate
  • Status changed from new to closed

Looks like we broke this in [25940]. From the discussion on #25495 the $this->public_query_vars was supposed to be assigned to the $public_query_vars variable to match the inline docs.

I'm going to close this as duplicate and reopen #25495.

#2 @DrewAPicture
6 years ago

In 25945:

Fix error introduced in [25940] where $public_query_vars should have only been used as a non-existent inline docs variable in the query_vars filter.

Restores $this->public_query_vars to the query_vars filter in wp-includes/class-wp.php.

Props mauryaratan.
Fixes #25495. See #25719.

#3 @SergeyBiryukov
6 years ago

  • Component changed from General to Query
  • Milestone Awaiting Review deleted

#4 @SergeyBiryukov
6 years ago

#25717 was marked as a duplicate.

#5 @Shapeshifter 3
6 years ago

I see that this was corrected in [25945].

My site still only displays a temporary static home page that I applied to it. Is there some way I can use the Beta Tester Plugin (or Automatic Updates) to add this correction to my site without waiting too much longer. (I realize it's a risk I take using nightly builds). I tried to downgrade to 3.7 by uninstalling the Beta Tester, but it didn't work. I'm still stuck on a mostly frozen 3.8.

Last edited 6 years ago by SergeyBiryukov (previous) (diff)

#6 @Shapeshifter 3
6 years ago

Is there any way I can get "hourly builds" besides "nightly builds" ?

#7 @Otto42
6 years ago

Shapeshifter: If you need this fix immediately, just download the class-wp.php file and replace the file in your installation with the fixed version manually:

http://core.svn.wordpress.org/trunk/wp-includes/class-wp.php

However, you should not run beta versions or nightly's on critical sites. If the site needs to be live and running at all times, then keep it on the stable version of the software.

#8 @Shapeshifter 3
6 years ago

Thanks Otto,

I know I'm pig headed. Sometimes I push things beyond their limits. Up until now I've gotten away with it.

Thanks for your help.

Note: See TracTickets for help on using tickets.