WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#25722 closed defect (bug) (fixed)

Hooks Docs: wp-includes/functions.wp-styles.php

Reported by: admiralthrawn Owned by: kpdesign
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Inline Docs Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

Inline docs for wp-includes/functions.wp-styles.php

Attachments (2)

25722.diff (539 bytes) - added by admiralthrawn 6 years ago.
25722.2.diff (799 bytes) - added by DrewAPicture 6 years ago.

Download all attachments as: .zip

Change History (8)

@admiralthrawn
6 years ago

#1 @admiralthrawn
6 years ago

  • Keywords has-patch added

#2 follow-up: @markoheijnen
6 years ago

  • Milestone changed from Awaiting Review to 3.8
  • Type changed from defect (bug) to enhancement

Doesn't the comment need to be inside the function? So then use brackets for it.

#3 in reply to: ↑ 2 @rmccue
6 years ago

Replying to markoheijnen:

Doesn't the comment need to be inside the function? So then use brackets for it.

With the current implementation, no, it just needs to be the first PHPDoc block before a "documentable" block (that is: class/function definition, or action/filter call). I'm not sure what the standard says on it though.

#4 @kpdesign
6 years ago

  • Milestone changed from 3.8 to Awaiting Review
  • Owner set to kpdesign
  • Status changed from new to reviewing
  • Type changed from enhancement to defect (bug)

@markoheijnen: @rmccue is correct, per the standard.

I'll start the reviews on the WC Sofia contributor day patches shortly.

@DrewAPicture
6 years ago

#5 @DrewAPicture
6 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.8

25722.2.diff looks good.

#6 @DrewAPicture
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 25950:

Inline documentation for hooks in wp-includes/functions.wp-styles.php.

Props admiralthrawn.
Fixes #25722.

Note: See TracTickets for help on using tickets.