WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#25740 closed defect (bug) (fixed)

Twenty Fourteen: Fix gallery posts in the ephemera widget

Reported by: iamtakashi Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:
PR Number:

Description

Currently the gallery posts in the ephemere widget are not working correctly. The issues are:

  • Total number of images in a gallery isn't correct.
  • Wrong cover image appears if none of gallery images is attached to the post.
  • Cover image and total number appear even a post is password protected.

Attachments (1)

25740.diff (5.3 KB) - added by iamtakashi 6 years ago.

Download all attachments as: .zip

Change History (4)

@iamtakashi
6 years ago

#1 @iamtakashi
6 years ago

  • Keywords has-patch added

Attached a patch that fixes the issue pointed above.

With this patch, I removed the fallback for featured image in gallery posts because only the gallery format does this and it may confuse users. Also I removed post ID from article to prevent duplicated IDs on a page because we are not removing the posts in the widget from the main query.

#2 @lancewillett
6 years ago

  • Milestone changed from Awaiting Review to 3.8
  • Summary changed from Twenty Fourteen: Fix gallery posts in the ephemere widget to Twenty Fourteen: Fix gallery posts in the ephemera widget

#3 @lancewillett
6 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 25970:

Twenty Fourteen: Fix gallery posts in the ephemera widget. Props iamtakashi, fixes #25740.

Note: See TracTickets for help on using tickets.