Make WordPress Core

Opened 11 years ago

Closed 10 years ago

#25746 closed defect (bug) (fixed)

Replying to comments from WP-Admin creates a text box the size of the comment to which one replies

Reported by: ipstenu's profile Ipstenu Owned by: azaozz's profile azaozz
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.3
Component: Comments Keywords: has-patch commit
Focuses: ui Cc:

Description

What happens/How to reproduce:

At wp-admin/edit-comments.php if you reply to a comment, the text-box size for your reply is the same size as the comment to which you are replying, which means if it's a very large comment, you get a similarly very large reply box.

What was expected:

Some sort of standard size (10 rows maybe?) would be better.

How long has this been going on?

Tested and this is a regression. Sorry. Worked up until 3.3

(Apologize to @nacin for not remembering to do this ... ages ago).

Attachments (2)

25746.patch (936 bytes) - added by SergeyBiryukov 11 years ago.
25746.2.patch (1.5 KB) - added by azaozz 10 years ago.

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
11 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.8

Introduced in [18576], where setting the height for #replycontent was moved out of the a == 'edit' condition. Also modified in [18803].

#2 @SergeyBiryukov
11 years ago

  • Keywords ui-focus commit added

#3 @dd32
11 years ago

@azaozz do you remember what case that was moved for?

@azaozz
10 years ago

#4 @azaozz
10 years ago

do you remember what case that was moved for?

As far as I remember, it was a users request (or a ticket?) but can't remember exactly, sorry.

In 25746.2.patch:

  • Resize the Quick Edit textarea only when editing a longer comment.
  • Limit the maximum height to 500px to make it more manageable for very long comments. Now in all newer browsers the users can adjust it if desired.
Version 0, edited 10 years ago by azaozz (next)

#5 @azaozz
10 years ago

  • Owner set to azaozz
  • Resolution set to fixed
  • Status changed from new to closed

In 26550:

Comments moderation screen:

  • Don't resize the textarea when replying to long comments.
  • Limit the resizing of the textarea when quick-editing long comments to 500px.

Props SergeyBiryukov, fixes #25746.

Note: See TracTickets for help on using tickets.