WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 3 of Ticket #25747


Ignore:
Timestamp:
10/31/2013 01:46:33 AM (11 years ago)
Author:
johnbillion
Comment:

There are actually several places where an HTTP request's return value doesn't trigger the http_api_debug action. None of the following responses trigger it:

  • Anything short-circuiting requests with the pre_http_request filter (​here).
  • Invalid URLs (​here).
  • Blocked requests (​here).
  • Unwritable directories when streaming (​here).

We might need a little refactoring here, or a helper method to trigger this action.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #25747

    • Property Keywords needs-patch added
    • Property Version changed from to 3.2
    • Property Summary changed from The `http_api_debug` hook isn't called when there are no available transports to The `http_api_debug` hook isn't called for all HTTP requests

  • Ticket #25747 – Description

    initial v3  
    11In `WP_Http::_dispatch_request()`, the `http_api_debug` action isn't called if there are no available transports for the request. This means we miss a situation that is ripe for debugging.
     2
     3'''Edit:''' There's more. See my comments below.