WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 2 months ago

#25754 closed enhancement (maybelater)

add jsonlint for our json files

Reported by: jorbin Owned by:
Milestone: Priority: normal
Severity: normal Version: 3.8
Component: Build/Test Tools Keywords: has-patch dev-feedback
Focuses: Cc:

Description

We now have jshint for validation on our javascript, we should also add jsonlint so that our json files receive similar love.

Attachments (1)

25754.diff (791 bytes) - added by jorbin 6 months ago.

Download all attachments as: .zip

Change History (6)

jorbin6 months ago

comment:1 jdgrimes6 months ago

  • Cc jdg@… added

comment:2 follow-up: nacin3 months ago

  • Component changed from General to Build Tools

Given that package.json is essentially a frozen file and our only JSON file, is it worth adding another dependency and an extra step to the build process?

comment:3 in reply to: ↑ 2 helen3 months ago

Replying to nacin:

Given that package.json is essentially a frozen file and our only JSON file, is it worth adding another dependency and an extra step to the build process?

Right now, probably not. Suggest maybelater.

comment:4 dd323 months ago

I tend to agree. This might be needed in the future if we have more often modified JSON files, but I don't think the benefits outweigh the extra dependency and build time right this instant.

comment:5 jorbin2 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to maybelater
  • Status changed from new to closed

Right now we only have the two json files (jshintrc and package.json). They have been edited 17 times in the last six months (so an average of almost 3 times per month). That is pretty low. I think if we start editing them more often or if we start adding more json files, this would make more sense.

Note: See TracTickets for help on using tickets.