WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#25757 closed defect (bug) (fixed)

Warning when auto-upgrading core

Reported by: pento Owned by:
Milestone: 3.7.1 Priority: normal
Severity: normal Version: 3.7
Component: Upgrade/Install Keywords: has-patch commit
Focuses: Cc:
PR Number:

Description

Warning: version_compare() expects parameter 2 to be string, object given in /srv/www/wordpress-default/wp-admin/includes/class-wp-upgrader.php on line 2138

Attachments (1)

25757.diff (830 bytes) - added by pento 6 years ago.

Download all attachments as: .zip

Change History (7)

@pento
6 years ago

#1 @SergeyBiryukov
6 years ago

  • Component changed from General to Upgrade/Install
  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.7.1

#2 @nacin
6 years ago

Just to confirm, version_compare() returns NULL in this case, so $newer_version_available would be false.

Basically, this variable is for using different language in the email when we've auto-updated them to 3.7.4 but 3.8.2 is available. If someone is on 3.7 and is somehow not auto-updated to 3.7.1, but they later enable automatic updates and get to the point where 3.7.4 and 3.8.2 are released at the same time, that's really the only time they'd be affected by this change.

#3 @nacin
6 years ago

I wish there was a way for us to "hotfix" this. As it stands this file clocks in at 2400 lines but isn't otherwise modified in 3.7.1, so it'll increase the size of the partial zip quite a bit. Not a big deal, though.

#4 @nacin
6 years ago

In 25977:

Use correct variable in WP_Automatic_Updater::send_email().

props pento.
see #25757 for trunk.

#5 @nacin
6 years ago

In 25981:

Use correct variable in WP_Automatic_Updater::send_email().

Merges [25977] to the 3.7 branch and adds an inline comment.

props pento.
see #25757.

#6 @nacin
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.