Opened 13 years ago
Closed 11 years ago
#25770 closed defect (bug) (maybelater)
manage_plugin-install_columns filter effects header columns, but not rows
| Reported by: | pdclark | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Plugins | Version: | 3.7.1 |
| Severity: | normal | Keywords: | needs-patch |
| Cc: | Focuses: | administration |
Description
The WP_List_Table class provides the filter "manage_{$this->screen->id}_columns" in __construct for editing columns that are displayed in the plugin table.
On the Install Plugins screen, the filter would be manage_plugin-install_columns or manage_plugin-install-network_columns.
Unfortunately, the implementation of WP_Plugin_Install_List_Table::display_rows() is inconsistent with WP_Plugins_List_Table::display_rows().
WP_Plugins_List_Table::single_row() correctly adds a row filter to match row columns to header columns:
echo "<td class='$column_name column-$column_name'$style>"; do_action( 'manage_plugins_custom_column', $column_name, $plugin_file, $plugin_data ); echo "</td>";
WP_Plugin_Install_List_Table::display_rows() causes column fails to filter columns — the headers filter is available, but no filter is used in the table body. Instead, the columns there are hard coded.
Can I get approval to patch this to make the two column listing methods consistent, and make the WP_Plugin_Install_List_Table::display_rows() use a column filter consistent with its own constructor?
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Patch away