WordPress.org

Make WordPress Core

Opened 6 months ago

Closed 3 weeks ago

#25772 closed defect (bug) (fixed)

Send back the original WP version after successful updates

Reported by: nacin Owned by: nacin
Milestone: 3.7.2 Priority: normal
Severity: normal Version: 3.7
Component: Upgrade/Install Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

After an update, wp_version_check() is used to refresh the update transient and some basic metrics. We were using the 'version' sent in wp_version_check() to figure out what version the user tried to update from. However, on a successful update, version.php is updated, so the internal inclusion in wp_version_check() gets the newer data. Thus many successes are showing up as successful 3.7.1 => 3.7.1 updates.

We should send back a 'reported' version in addition to 'attempted'.

Attachments (1)

25772.diff (552 bytes) - added by nacin 6 months ago.

Download all attachments as: .zip

Change History (6)

nacin6 months ago

comment:1 dd325 months ago

In 26016:

Core Upgrader success statistics: Pass the version of WordPress we're upgrading from, as well as the version being upgraded to. Props nacin. See #25772 for trunk

comment:2 dd325 months ago

  • Keywords has-patch commit added

Still needs back porting. API has been updated to handle the data.

comment:3 dd325 months ago

In 26017:

Core Upgrader: Include an unmodified $wp_version in Core_Upgrader::upgrade(). This protects against cases where the global $wp_version has been modified. See #25772

comment:4 dd325 months ago

  • Keywords fixed-major added

comment:5 nacin3 weeks ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 27883:

Core Upgrader success statistics: Pass the version of WordPress we're upgrading from, as well as the version being upgraded to.

Merges [26016] and [26017] from 3.8 to the 3.7 branch.

fixes #25772.

Note: See TracTickets for help on using tickets.