WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 2 years ago

#25824 closed task (blessed) (fixed)

Merge dashboard page plugin into core

Reported by: lessbloat Owned by:
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Administration Keywords:
Focuses: Cc:
PR Number:

Description

As a 3.8 feature as a plugin we took a stab at simplifying/improving the dashboard page you land on when you log in. Here's a recap of what we changed: http://make.wordpress.org/core/2013/10/23/dash-3-8-proposal/

This ticket will be used to merge the plugin located at: https://github.com/growthdesigner/wp-dash into core.

Attachments (13)

25824.diff (70.9 KB) - added by lessbloat 6 years ago.
25824.1.diff (86.9 KB) - added by lessbloat 6 years ago.
25824.2.diff (101.6 KB) - added by lessbloat 6 years ago.
25824.3.diff (100.9 KB) - added by lessbloat 6 years ago.
25824.4.diff (82.2 KB) - added by lessbloat 6 years ago.
25824.5.diff (82.3 KB) - added by lessbloat 6 years ago.
DASH-notice.diff (541 bytes) - added by MikeHansenMe 6 years ago.
Check if SCRIPT_DEBUG is defined
25824.i18n.patch (2.4 KB) - added by dimadin 6 years ago.
25824.6.diff (3.5 KB) - added by lessbloat 6 years ago.
25824.7.diff (6.3 KB) - added by lessbloat 6 years ago.
25824.8.diff (321 bytes) - added by SergeyBiryukov 6 years ago.
25824.js.diff (2.1 KB) - added by helen 6 years ago.
25824.js.2.diff (2.1 KB) - added by kadamwhite 6 years ago.
Altered resize event handler syntax for readability and made spacing changes from 25824.js.diff

Download all attachments as: .zip

Change History (55)

#1 @helen
6 years ago

  • Type changed from defect (bug) to task (blessed)

#2 @DrewAPicture
6 years ago

  • Cc xoodrew@… added

@lessbloat
6 years ago

#3 @lessbloat
6 years ago

First pass at a merge in 25824.diff​:

  • Added temporary_dash_styles() & temporary-dash-styles.css as a stop-gap for adding styles until MP6 is in core
  • Removes wp_dashboard_primary (old wordpress.org/news/ feed widget)
  • Removes wp_dashboard_secondary (old planet.wordpress.org feed widget)
  • Removes plugin widget
  • Removes incoming links widget
  • Merged new dashboard_rss (WordPress News) widget
  • Removed "configure" options from WordPress News widget
  • Removed recent drafts widget
  • Removed quick press widget
  • Added new quick draft widget (new simplified quick press plus quick drafts in one)
  • Removed recent comments widget
  • Added new activity widget

Remaining Todos: (that I know of)

  • RTL testing
  • Test Browse happy box on dashboard
  • Remove newest plugins from "WordPress News"
  • Show popular plugins in "WordPress News", unless you already have them installed
  • Look at weird column widths (menu bar collapsed, at 1400px)
  • New API for the Right Now box?
  • Add any deprecated functions
  • @markjaquith's code review

#4 @Joen
6 years ago

  • Cc asmussen@… added

@lessbloat
6 years ago

#5 @lessbloat
6 years ago

25824.1.diff​ refreshes 25824.diff​ and adds in the missing wp-admin/css/temporary-dash-styles.css file.

@lessbloat
6 years ago

#6 @lessbloat
6 years ago

25824.2.diff​:

  • Adds RTL CSS
  • Adds custom H2's (Hola, Aloha, etc...)
  • Adds updated help text
  • Removes "Columns" screen option

Remaining TODOS (that I know of)

  • Test Browse happy box on dashboard
  • Remove newest plugins from "WordPress News"
  • Show popular plugins in "WordPress News", unless you already have them installed
  • Look at weird column widths (menu bar collapsed, at 1400px)
  • New API for the Right Now box? (not sure what this would entail)
  • Add any deprecated functions
  • @markjaquith's code review

@lessbloat
6 years ago

#7 @lessbloat
6 years ago

25824.3.diff​ also:

  • Removes custom H2's (Hola, Aloha, etc...). Helen made a comment to me about not liking 'It's Go Time', 'Break a Leg', 'Go For Broke'. I agreed, and if felt weird having only a hand full of greetings rotating through there (plus complications around translating those greetings). Decided to pull it. Happy to discuss, if anyone feels passionate about keeping them.
  • Fixes formatting for browse happy box on dashboard
  • Removes newest plugins from "WordPress News"
  • Added visible dashed box lines back at 1400px browser resolution, so it doesn't look as though the 3rd & 4th columns are busted.

Remaining TODOS (that I know of)

  • Show popular plugins in "WordPress News", unless you already have them installed
  • New API for the Right Now box? (not sure what this would entail)
  • Add any deprecated functions
  • @markjaquith's code review

@lessbloat
6 years ago

#8 @lessbloat
6 years ago

Now that MP6 is merged in, 25824.4.diff​ removed the temporary hacked in style sheet (temporary-dash-styles.css).

@lessbloat
6 years ago

#9 @lessbloat
6 years ago

25824.5.diff​ strips some whitespace.

#10 @nacin
6 years ago

In 26144:

Merge the new dashboard design into core.

Merges https://github.com/growthdesigner/wp-dash.

props lessbloat, joen, helen, dbernar1, kraftbj, ryelle, tillkruess, grapplerulrich, markjaquith.
see #25824.

#11 @MikeHansenMe
6 years ago

  • Cc mdhansen@… added

Currently DASH throws a notice when SCRIPT_DEBUG is not defined

@MikeHansenMe
6 years ago

Check if SCRIPT_DEBUG is defined

#12 @helen
6 years ago

That's actually not DASH's fault - it's from color schemes.

#13 @helen
6 years ago

In 26146:

Avoid a notice when SCRIPT_DEBUG is not defined. props MikeHansenMe. see #25824, #25858.

#14 follow-up: @dimadin
6 years ago

I investigated i18n issues in [26144] and found more than I expected. Patch has a few easy ones but since I see this is unfinished code I didn't want to touch others before asking are there any more changes planned.

Listing here for future reference.

wp-admin/includes/dashboard.php:

  • Generally texts in printf functions aren't i18n so there is no way to change word order
  • L178: no plural forms for post types; this will be tricky to implement because of those that aren't built-in
  • L194
  • L379
  • L576
  • L675 (related to L576)
  • L921
  • L958

wp-admin/post.php:

  • L197: I assume these are meant to be changed but still this was poorly done considering that it's related to <?php _e( $error_msg ); ?> in wp_dashboard_quick_draft()

@dimadin
6 years ago

#15 @nacin
6 years ago

In 26183:

Clean up wp-admin/index.php after dash merge. see #25824.

@lessbloat
6 years ago

#16 @lessbloat
6 years ago

25824.6.diff​ includes some padding and margin niggles. Should fix:

Note: The Jetpack Stats widget still has some minor padding adjustments needed, but I'll make those tweaks in Jetpack.

Last edited 6 years ago by lessbloat (previous) (diff)

#17 @nacin
6 years ago

In 26220:

Dash cleanup.

  • Use wp_add_dashboard_widget() rather than add_meta_box().
  • Use original functions like wp_dashboard_primary(), wp_dashboard_right_now(), wp_dashboard_quick_press() (where possible).
  • Only include plugins section of the news widget when appropriate, which necessitates the set_current_screen() via the ajax action.
  • Remove some debug cruft that was preventing caching and invalidation.
  • Simplify lots of things where possible.

see #25824.

#18 @nacin
6 years ago

In 26221:

Merge wp_dashboard_recent_quickdrafts() into wp_dashboard_quick_press(). see #25824.

@lessbloat
6 years ago

#19 @lessbloat
6 years ago

25824.7.diff​:

  • Refreshes wp-admin.css tweaks in 25824.6.diff​.
  • Eliminates <div class='rss-title-row'> changes to in default-widgets.php (which was a RTL hack that wasn't even needed).
  • Fixes 1 fatal in wp-admin/post.php when submitting a quick draft.
  • Fixes auto-populating and highlighting of quick draft ideas upon submit

#20 @nacin
6 years ago

In 26230:

More dash updates.

  • Shuffle around some pixels.
  • Rename some things that weren't caught in [26220].
  • Revert default-widgets.php change from [26144].

props lessbloat.
see #25824.

#21 @nacin
6 years ago

In 26231:

Revert these action blocks in wp-admin/post.php to their pre-[26144] state.

see #25824.

#22 @SergeyBiryukov
6 years ago

25824.8.diff removes a redundant line. It's already covered by line 2586:
trunk/src/wp-admin/css/wp-admin.css?rev=26230#L2585.

#23 in reply to: ↑ 14 @SergeyBiryukov
6 years ago

Replying to dimadin:

L178: no plural forms for post types; this will be tricky to implement because of those that aren't built-in

Related: #26066

#24 @SergeyBiryukov
6 years ago

In 26240:

Fix CSS formatting. Remove redundant rule. see #25976. see #25824.

#25 @SergeyBiryukov
6 years ago

In 26241:

PHPDoc and i18n fixes for dashboard widgets.

props dimadin for initial patch.
see #25824.

#26 follow-up: @DrewAPicture
6 years ago

At 1440x900 resolution, I'm now getting three columns where I previously had two. And as such, the 2 left columns (the third is empty), are pretty scrunched. Maybe we should consider increasing the breakpoint a little bit.

http://f.cl.ly/items/3l2o0j1r2b3b0b3N3y47/Screen%20Shot%202013-11-18%20at%202.00.25%20PM.png

If I bring down the window width just a bit, it hits the breakpoint and I see what I'd expect:

http://f.cl.ly/items/0t0a0x3H1w1g3s0Z1W2j/Screen%20Shot%202013-11-18%20at%202.02.10%20PM.png

#27 in reply to: ↑ 26 @SergeyBiryukov
6 years ago

Replying to DrewAPicture:

At 1440x900 resolution, I'm now getting three columns where I previously had two. And as such, the 2 left columns (the third is empty), are pretty scrunched. Maybe we should consider increasing the breakpoint a little bit.

Related: #26074

#28 @nacin
6 years ago

In 26291:

Dash cleanup.

  • Use wp_add_dashboard_widget() rather than add_meta_box().
  • Use original functions like wp_dashboard_primary(), wp_dashboard_right_now(), wp_dashboard_quick_press() (where possible).
  • Only include plugins section of the news widget when appropriate, which necessitates the set_current_screen() via the ajax action.
  • Remove some debug cruft that was preventing caching and invalidation.
  • Simplify lots of things where possible.

see #25824.

#29 @nacin
6 years ago

Oops, [26291] accidentally used the commit message of [26220]. The proper commit message:

Big code cleanup of the new themes.php design.

Tighter Backbone code, classes versus IDs, fixes bugs with the overlay and broken themes, etc.

props matveb, nacin.
see #25948.

#30 @ocean90
6 years ago

In 26337:

Dashboard: Use _draft_or_post_title() to display (no title) if no post title is set. see #25824.

#31 follow-up: @ocean90
6 years ago

Shouldn't wp_dashboard_activity() be hidden in Network Admin?

@helen
6 years ago

#32 @kadamwhite
6 years ago

I'd opt for the more explicit "on" syntax for the event handler:

$window.on( 'resize', _.debounce(function() { 
    updateColumnCount( $window, metaboxHolder ); 
}, 30 ));

Makes it more obvious you're telling the browser to do something ON resize, and not to, in fact, resize the browser (which in my experience most people new to jQuery think ".resize" does by default)

Reviewing the rest now

#33 @kadamwhite
6 years ago

updateColumnCount should also probably take a $window argument, not window, since you're passing in the jQuery object and not the native DOM window object.

@kadamwhite
6 years ago

Altered resize event handler syntax for readability and made spacing changes from 25824.js.diff

#34 @helen
6 years ago

In 26390:

Dashboard JS cleanup. props kadamwhite, helen. see #25824.

#35 in reply to: ↑ 31 @helen
6 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Replying to ocean90:

Shouldn't wp_dashboard_activity() be hidden in Network Admin?

#26184

Closing as fixed. New tickets for remaining or new issues, please.

#36 @helen
6 years ago

In 26656:

Restore CSS for the Site Content, née Right Now, Dashboard widget. Removes a nice large swath of unnecessary styles. fixes #26392, see #25824.

#37 @nacin
6 years ago

In 26690:

Dashboard backwards compatibility updates.

  • Restore missing wp_dashboard_rss_control() helper.
  • Restore all original 3.7 functions, deprecating many, reusing others.
  • Rename and remove functions so as not to clash with the original dash plugin.
  • Filter cleanup/restoration.

see #25824, #26334.

#38 @nacin
6 years ago

Had a conversation with some other core team members about "Site Content". It's not just your content; it's also your theme, your version, how much spam you have, and potentially other things. It's also really boring.

The ideas/thoughts we had: "Site Overview", "Overview", "About this Site" (like "About this Mac"). "This Site" sounded like extraneous labeling, kind of like "Site Content". "Summary". But "About" could conflate with "About WordPress."

We settled on "At a Glance," an idiom that is simple and classy. It also suggests to plugin authors what should be put here.

If translators want to use something more straightforward (if the idiom doesn't translate well in their language), they can (and do in other contexts already).

#39 @nacin
6 years ago

In 26697:

Dashboard: Rename the Site Content widget (née Right Now) to At a Glance.

see #25824.

#40 @azaozz
6 years ago

In 26784:

Dashboard: set two columns as default for IE8 (as it doesn't support @media rules), see #25824.

#41 @TimothyBlynJacobs
6 years ago

Curious, why were the activity hooks removed? I was looking forward to using them.

#42 @DrewAPicture
2 years ago

@nacin In [26690], you (rightly) restored a whole bunch of dashboard widget control callbacks, albeit soft-deprecated. Are we to a point where we can hard-deprecate them now with _deprecated_function() calls? See #41121.

Note: See TracTickets for help on using tickets.