Make WordPress Core

Opened 11 years ago

Closed 11 years ago

Last modified 8 years ago

#25831 closed defect (bug) (fixed)

Clicking "Check Again" within 1 minute of a previous check does nothing

Reported by: dd32's profile dd32 Owned by: dd32's profile dd32
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch 2nd-opinion
Focuses: Cc:

Description (last modified by dd32)

On the Updates page, clicking "Check Again" within 1 minute of the last core update check doesn't actually do anything.. This is because the cache lasts for at least 1 minute.

This is particularly annoying for development users who change the version string as it leads to a frustrating minute.

One other potential way to approach this is that $wp_version should invalidate the existing transient somehow.

Attachments (1)

25831.diff (1.6 KB) - added by dd32 11 years ago.

Download all attachments as: .zip

Change History (6)

#1 @dd32
11 years ago

  • Description modified (diff)
  • Summary changed from Clicking "Check Now" within 1 minute of a previous check does nothing to Clicking "Check Again" within 1 minute of a previous check does nothing

11 years ago

#2 @dd32
11 years ago

  • Keywords has-patch 2nd-opinion added

25831.diff tackles it from both angles

  • Adds a parameter to force-check for new updates, it relies on the fact that extra stats bypass the update-check limiter.
  • Adds $wp_version invalidation.

I'm not certain that the force-check should be added, although it does make the button do what it says.
The $wp_version invalidation seems appropriate.

#3 @dd32
11 years ago

In 26188:

Invalidate the 'update_core' Update check transient when $wp_version changes. See #25831

#4 @dd32
11 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 26192:

Updates: Force an update check to occur when the 'Check Again' button is used in the Dashboard. Fixes #25831

This ticket was mentioned in Slack in #feature-shinyupdates by ocean90. View the logs.

8 years ago

Note: See TracTickets for help on using tickets.