WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 2 years ago

#25832 closed defect (bug) (fixed)

Hook Docs (9): wp-admin/includes/image.php

Reported by: theorboman Owned by: kpdesign
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch commit
Focuses: docs Cc:

Description

Adding inline doc to all the hooks in wp-admin/includes/image.php

Attachments (7)

25832.patch (4.1 KB) - added by theorboman 3 years ago.
patch for inline docs
25832.1.diff (4.1 KB) - added by theorboman 3 years ago.
Improved patch. All @since tags now in the correct format (X.X.X)
25832.1.patch (4.1 KB) - added by theorboman 3 years ago.
Improved patch. All @since tags now in the correct format (X.X.X)
25832.2.diff (4.1 KB) - added by theorboman 3 years ago.
Fixed indentation (again!)
25832.diff (4.2 KB) - added by DrewAPicture 2 years ago.
3rd pass
25832.3.diff (4.4 KB) - added by kpdesign 2 years ago.
Final pass
25832.4.diff (4.8 KB) - added by DrewAPicture 2 years ago.

Download all attachments as: .zip

Change History (18)

@theorboman
3 years ago

patch for inline docs

@theorboman
3 years ago

Improved patch. All @since tags now in the correct format (X.X.X)

@theorboman
3 years ago

Improved patch. All @since tags now in the correct format (X.X.X)

#1 @theorboman
3 years ago

Sorry, uploaded the improved patch with incorrect name! 25832.1.diff​ and 25832.1.patch are the same.

#2 @kpdesign
3 years ago

  • Owner set to kpdesign
  • Status changed from new to reviewing

#3 @kpdesign
3 years ago

  • Owner changed from kpdesign to DrewAPicture

#4 @DrewAPicture
3 years ago

  • Keywords needs-patch added; has-patch removed
  • Summary changed from Hooks Docs: wp-admin/includes/image.php to Hook Docs (9): wp-admin/includes/image.php

25832.1.diff looks like a pretty good start. Could use some help in the spacing department.

#5 @theorboman
3 years ago

I've attached another patch for this. I neglected to add full stops (sorry, periods - I'm Irish) to the docs so I've added them in now.

I've also fixed the spacing stuff. I was trying to make it all align but obviously that wasn't such a good idea!

@theorboman
3 years ago

Fixed indentation (again!)

#6 @kpdesign
3 years ago

  • Keywords has-patch added; needs-patch removed

#7 @jeremyfelt
3 years ago

  • Component changed from Inline Docs to Media
  • Focuses docs added

@DrewAPicture
2 years ago

3rd pass

#8 @DrewAPicture
2 years ago

  • Owner changed from DrewAPicture to kpdesign

25832.diff takes a pass at fixing up and standardizing some language.

Next steps:

  • Confirm @since versions
  • Give the language a once-over
  • Review and recommend

@kpdesign
2 years ago

Final pass

#9 @kpdesign
2 years ago

  • Keywords commit added

25832.3.diff contains minor formatting corrections, fixes some language in 25832.diff.

This one is ready to go in. Recommend commit.

@DrewAPicture
2 years ago

#10 @DrewAPicture
2 years ago

  • Milestone changed from Awaiting Review to 3.9

25832.4.diff should do it.

#11 @DrewAPicture
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 27202:

Inline documentation for hooks in wp-admin/includes/image.php.

Props theorboman, kpdesign.
Fixes #25832.

Note: See TracTickets for help on using tickets.