WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#25839 closed defect (bug) (fixed)

Hook Docs (5): wp-admin/includes/class-wp-media-list-table.php

Reported by: theorboman Owned by: kpdesign
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Media Keywords: has-patch commit
Focuses: docs Cc:

Description

Adding inline doc to all the hooks in wp-admin/includes/class-wp-media-list-table.php

Attachments (3)

25839.patch (2.6 KB) - added by theorboman 7 years ago.
Patch for inline docs
25839.2.patch (2.9 KB) - added by DrewAPicture 7 years ago.
Second pass.
25839.3.patch (2.9 KB) - added by kpdesign 7 years ago.
Third pass

Download all attachments as: .zip

Change History (12)

#1 @kpdesign
7 years ago

  • Keywords needs-patch added

@theorboman
7 years ago

Patch for inline docs

#2 @theorboman
7 years ago

  • Keywords has-patch added; needs-patch removed

#3 @kpdesign
7 years ago

  • Owner set to kpdesign
  • Status changed from new to reviewing

#4 @DrewAPicture
7 years ago

  • Keywords needs-patch added; has-patch removed
  • Summary changed from Hook Docs: wp-admin/includes/class-wp-media-list-table.php to Hook Docs (5): wp-admin/includes/class-wp-media-list-table.php

25839.patch is a great first patch. Looks like there are some spacing issues, and a few docs-specific parameter variables need to be used as well.

@DrewAPicture
7 years ago

Second pass.

#5 @DrewAPicture
7 years ago

  • Keywords has-patch docs-feedback added; needs-patch removed
  • Milestone changed from Awaiting Review to 3.9

25839.2.patch applies the suggested changes from comment:4 and clarifies some language. Needs a secondary review.

@kpdesign
7 years ago

Third pass

#6 @kpdesign
7 years ago

  • Keywords commit added; docs-feedback removed

25839.3.patch provides changes for consistency in language used.

I think this one's a good commit candidate.

#7 @DrewAPicture
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 26916:

Inline documentation for hooks in wp-admin/includes/class-wp-media-list-table.php.

Props theorboman for the initial patch. Props kpdesign.
Fixes #25839.

#8 @DrewAPicture
6 years ago

  • Focuses docs added

#9 @DrewAPicture
6 years ago

  • Component changed from Inline Docs to Media
Note: See TracTickets for help on using tickets.