Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#25859 closed defect (bug) (fixed)

Twenty Fourteen: Remove placeholders for featured images

Reported by: iamtakashi Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.8
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:


We've been discussing about the placeholders since the beginning. The purpose of the placeholders was to encourage users to attach featured images that make this theme to have the best look. This is originated with the base theme, Further, being specifically designed as a magazine theme where featured image is one of the most common elements.

However, after hearing invaluable feedback, I'm removing the placeholders. Still the theme will look way better with featured images and users who decide to add them will get the best of it but removing the placeholders will make it more general as a default theme and will broaden the use cases for the theme, for example, less image blogs and sites.

Attachments (2)

25859.diff (16.3 KB) - added by iamtakashi 2 years ago.
25859.2.diff (9.8 KB) - added by iamtakashi 2 years ago.

Download all attachments as: .zip

Change History (7)

2 years ago

#1 @iamtakashi
2 years ago

  • Keywords has-patch added

Attached a patch removing placeholders for featured images. I've also fixed some inconsistency between templates I've noticed during this process.

#2 @obenland
2 years ago

  • Milestone changed from Awaiting Review to 3.8

#3 @lancewillett
2 years ago

Looks like you have a lot of other changes in the patch -- can you reduce it to just the placeholder image changes, please? We can get the rest in separately.

2 years ago

#4 @iamtakashi
2 years ago

Sorry about that! Here is the updated patch.

I'll do the clean-up separately.

#5 @lancewillett
2 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 26034:

Twenty Fourteen: remove the pattern image used as a placeholder for featured images. This greatly improves the "first run" experience of the theme and gives it a more general appeal as a blog theme by putting less of a requirement on featured images. Props iamtakashi, fixes #25859.

Note: See TracTickets for help on using tickets.