Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#25860 closed defect (bug) (fixed)

Copy version.php last during updates

Reported by: dd32 Owned by: dd32
Milestone: 3.9 Priority: normal
Severity: normal Version:
Component: Upgrade/Install Keywords: has-patch needs-testing
Focuses: Cc:


Sometimes when updating, the process fails mid-way due to circumstances out of our control.

In some cases, version.php may be copied before the error occurs, when this happens WordPress believes that it's $new_version rather than the previous version.

We should instead, only copy version.php over last, so as to ensure that we don't end up in that situation.

Attachments (1)

25860.diff (1.5 KB) - added by dd32 8 years ago.

Download all attachments as: .zip

Change History (7)

#1 @nacin
8 years ago

  • Milestone changed from Awaiting Review to 3.9

I agree with this, let's do it.

8 years ago

#2 @dd32
8 years ago

  • Keywords has-patch needs-testing added; needs-patch removed

Attached an untested patch of what I had locally

#3 @dd32
8 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 27336:

Upgrader: Copy wp-includes/version.php over last, to avoid an installation failing with the new version.php in place. Fixes #25860

#4 @dd32
8 years ago

In 27337:

Upgrader: Remove two stray spaces. See #25860

#5 @dd32
8 years ago

In 27338:

Upgrader: Remove some debug from r27336. See #25860

#6 @dd32
8 years ago

In 27339:

Upgrader: Remove more debug from r27336. See #25860

Note: See TracTickets for help on using tickets.