favicon requests not caught when WP is installed in a subfolder

[Denis-de-Bernardy]

We introduced a favicon.ico handler four years ago, but it only handles requests on sites installed in a root folder.

In case the attached git diff doesn't want to apply to svn, it basically amends the first line of wp_favicon_request() in wp-includes/load.php, like so:

function wp_favicon_request() {
	if ('/favicon.ico' == substr($_SERVER['REQUEST_URI'], -12)) {
		header('Content-Type: image/vnd.microsoft.icon');
		header('Content-Length: 0');
		exit;
	}
}

[dd32]

The favicon standard is on a domain-basis, as such, browsers only look in /, they won't look in /wordpress/.

A Theme can specify a custom location through link tags however.

So I'm not sure this patch will actually do anything at all?

[Denis-de-Bernardy]

Yep, my bad. I needed to toss in a blank file in my localhost root. Sorry 'bout that.

[TobiasBg]

#31305 was marked as a duplicate.