WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#25867 closed defect (bug) (fixed)

Admin CSS: Make suggest script visible in customizer

Reported by: celloexpressions Owned by: SergeyBiryukov
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch commit
Focuses: ui Cc:

Description

Related: #25618. We need to assign a much larger z-index for the suggest script so that it is visible in the customizer. Currently it is hidden behind everythign else (see http://core.trac.wordpress.org/ticket/25549#comment:31).

This is needed for Twenty Fourteen's featured content implementation.

Attachments (4)

25867.diff (373 bytes) - added by celloexpressions 7 years ago.
Bump up the z-index for the suggest script's div so that it is visible in the customizer.
25867.mp6.diff (346 bytes) - added by celloexpressions 7 years ago.
Patched against mp6's wp-admin.css.
25867.2.diff (776 bytes) - added by SergeyBiryukov 7 years ago.
25867.3.diff (1.4 KB) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (13)

#1 @lancewillett
7 years ago

  • Cc lancewillett added
  • Milestone changed from Awaiting Review to 3.8

@celloexpressions
7 years ago

Bump up the z-index for the suggest script's div so that it is visible in the customizer.

#2 @celloexpressions
7 years ago

Patch gives the suggest script a high enough z-index to be visible in the customizer. Unfortunately this is much higher than the admin bar's z-index, but there's no way to distinguish between the admin and the customizer with css so we'll have to go with it. Only other option is to make the z-indicies on the customizer saner, although that could break things (wondering why they're so high in the first place).

#3 @lancewillett
7 years ago

  • Keywords has-patch added; needs-patch removed
  • Summary changed from Make suggest script visible in customizer to Twenty Fourteen: make suggest script visible in customizer

#4 @lancewillett
7 years ago

  • Summary changed from Twenty Fourteen: make suggest script visible in customizer to Admin CSS: Make suggest script visible in customizer

Oops, bad title change, sorry.

@celloexpressions
7 years ago

Patched against mp6's wp-admin.css.

#5 @SergeyBiryukov
7 years ago

  • Keywords ui-focus added

#6 @SergeyBiryukov
7 years ago

  • Keywords commit added

25867.2.diff adds wp-customizer class to only target the customizer.

#7 @SergeyBiryukov
7 years ago

25867.3.diff also removes the code for adding the inline style from Twenty Fourteen.

#8 @SergeyBiryukov
7 years ago

In 26085:

Make suggest script visible in the customizer.

props celloexpressions for initial patch.
see #25867.

#9 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26086:

Remove the code for increasing z-index for the tag suggestion script from Twenty Fourteen.

fixes #25867.

Note: See TracTickets for help on using tickets.