WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#25869 closed defect (bug) (fixed)

Twenty Fourteen: Screens with 1440px or less are not displayed background area while customizing

Reported by: rachelbaker Owned by:
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

Originally pointed out during TwentyFourteen IRC discussion from today. With a screen resolution of 1440px or less users that use the Theme Customizer to edit the theme's background color and image never see the background. This is due to the extra screen real-estate used by the Customizer sidebar, that is not accounted for when the theme previews are displayed.

Attachments (3)

twentyfourteen-backgroundnotdisplaying-incustomizer.png (219.6 KB) - added by rachelbaker 7 years ago.
Twentyfourteen Theme Customizer cannot see background during customization.
25869.patch (1.2 KB) - added by rachelbaker 7 years ago.
Added section descriptions to Background Image and Colors default sections.
25869-1.patch (1.2 KB) - added by rachelbaker 7 years ago.
fixes syntax error and missing text domain.

Download all attachments as: .zip

Change History (12)

@rachelbaker
7 years ago

Twentyfourteen Theme Customizer cannot see background during customization.

@rachelbaker
7 years ago

Added section descriptions to Background Image and Colors default sections.

#1 @rachelbaker
7 years ago

  • Keywords dev-feedback has-patch added; needs-patch removed

Added description text to Background Image and Colors sections to help alleviate user confusion. The section description in the Colors section does seem a bit awkward with the additional "Accent" color option there.

#2 @rachelbaker
7 years ago

Corrected syntax error and added text domain to Colors section.

@rachelbaker
7 years ago

fixes syntax error and missing text domain.

#3 @rachelbaker
7 years ago

This is intended to be a short-term fix while we draft another solution for inline help and support for users within the Theme Customizer.

#4 @rachelbaker
7 years ago

  • Summary changed from Screens with 1440px or less resolution are not displayed background area while customizing to Twentyfourteen: Screens with 1440px or less are not displayed background area while customizing

#5 @rachelbaker
7 years ago

  • Summary changed from Twentyfourteen: Screens with 1440px or less are not displayed background area while customizing to Twenty Fourteen: Screens with 1440px or less are not displayed background area while customizing

#6 @obenland
7 years ago

I don't think it is necessary to add our own versions of the two sections. We can just modify the existing ones like we do with the transport methods.

#7 @lancewillett
7 years ago

In 26038:

Twenty Fourteen: add contextual help text to Background and Colors controls in Customizer, using the description field. Props rachelbaker, see #25869.

#8 @lancewillett
7 years ago

In 26039:

Twenty Fourteen: better override for Background and Colors descriptions in Customizer, props obenland. See #25869.

#9 @lancewillett
7 years ago

  • Keywords dev-feedback removed
  • Milestone changed from Awaiting Review to 3.8
  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.