WordPress.org

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#2587 closed defect (bug) (fixed)

New template function: wp_list_bookmarks()

Reported by: ryan Owned by: westi
Milestone: 2.1 Priority: normal
Severity: normal Version: 2.1
Component: Administration Keywords: bookmarks lists has-patch
Focuses: Cc:

Description

wp_list_bookmarks() will replace get_links_list() and get_links(). By default, it should create a list of all bookmarks organized by category. We want to avoid the mistake of hard coding h2s and other formatting, so there should be options for specifying any formatting that should come before and after each category heading. wp_list_bookmarks() should also allow creating a big list of uncategorized bookmarks as well as listing bookmarks in a specific category or set of categories. A stub for wp_list_bookmarks() exists in template-functions-bookmarks.php along with some implementation notes. wp_list_bookmarks() should use get_bookmarks() for querying the DB.

Attachments (1)

2587.wp_list_bookmarks.diff (2.7 KB) - added by westi 9 years ago.
Implement the rest of wp_list_bookmarks

Download all attachments as: .zip

Change History (12)

comment:1 @MichaelH9 years ago

Question on this requirement--"as well as listing bookmarks in a specific category or set of categories".

If it's a 'set of categories' does that imply allowing something like 'category=1,4,7,9'? If yes, should get_bookmarks() be changed to handle that?

comment:2 @ryan9 years ago

Yes and yes.

comment:4 @ryan9 years ago

[3880] first pass

comment:5 @westi9 years ago

  • Owner changed from anonymous to westi
  • Status changed from new to assigned

Quite a bit of the support code for this seems in good shape.

I'm working on finishing off coding wp_list_bookmarks against the requirements spec.
I'll upload a patch when I've got a bit more finished.

@westi9 years ago

Implement the rest of wp_list_bookmarks

comment:6 @westi9 years ago

  • Keywords has-patch added

Attached patch implements the rest of wp_list_bookmarks I believe

comment:8 follow-up: @foolswisdom9 years ago

westi, ryan, is there still more to do for this bug? Or should it be closed?

comment:9 in reply to: ↑ 8 @westi9 years ago

Replying to foolswisdom:

westi, ryan, is there still more to do for this bug? Or should it be closed?

I don't think this is complete yet.

I think we now need to move the deprecated functions to deprecated.php and implement them as calls to the new function.

I guess that is why ryan left the ticket open?

comment:10 @matt9 years ago

  • Milestone changed from 2.1 to 2.2

comment:11 @ryan9 years ago

  • Milestone changed from 2.2 to 2.1
  • Resolution set to fixed
  • Status changed from assigned to closed

Actually, this is done.

Note: See TracTickets for help on using tickets.