WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#25874 closed defect (bug) (fixed)

Missing parenthesis in get_bookmarks is breaking Links

Reported by: batmoo Owned by: dd32
Milestone: 3.8 Priority: normal
Severity: blocker Version: 3.8
Component: General Keywords: has-patch commit
Focuses: Cc:

Description

r25934 introduce a bug in get_bookmarks because it's missing paranthesis around the cache check:

if ( is_array($cache) && isset( $cache[ $key ] ) ) 

We end up doing an early return because the apply_filters call isn't contained within the parenthesis.

This is causing the Links section to break.

Attachments (1)

25874.diff (934 bytes) - added by batmoo 7 years ago.

Download all attachments as: .zip

Change History (5)

@batmoo
7 years ago

#1 @batmoo
7 years ago

  • Keywords has-patch added

Patch adds missing parentheses.

#2 @ocean90
7 years ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 3.8

#3 @dd32
7 years ago

  • Owner set to dd32
  • Resolution set to fixed
  • Status changed from new to closed

In 26046:

Add some missing braces to get_bookmarks() which was causing an early return. Introduced in [25934]. See #25468. Fixes #25874

#4 @dd32
7 years ago

Props to batmoo for that patch, had to apply manually and forgot!

Note: See TracTickets for help on using tickets.