WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#25877 closed defect (bug) (fixed)

jshint shouldn't throw errors - wp-admin/js/color-picker.js

Reported by: jorbin Owned by: nacin
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description


Attachments (5)

25877.global.diff (440 bytes) - added by jorbin 8 years ago.
25877.singlequotes.diff (1.9 KB) - added by jorbin 8 years ago.
25877.semicolon.diff (405 bytes) - added by jorbin 8 years ago.
25877.vars.diff (1.1 KB) - added by jorbin 8 years ago.
25877.diff (1.0 KB) - added by kadamwhite 8 years ago.
Spaces -> Tabs, adjust variable declaration to match style guide

Download all attachments as: .zip

Change History (10)

@jorbin
8 years ago

@jorbin
8 years ago

#1 @jorbin
8 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 3.8

#2 @jorbin
8 years ago

  • Component changed from Unit Tests to Build Tools

#3 @nacin
8 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26067:

Avoid JSHint errors in color-picker.js. One var, single quotes, add missing semicolon, declare wpColorPickerL10n as global.

props jorbin.
fixes #25877.

@kadamwhite
8 years ago

Spaces -> Tabs, adjust variable declaration to match style guide

#4 @kadamwhite
8 years ago

This has landed so it's irrelevant, but I did fix spaces to tabs and altered the variable declaration order to be more readable—Large objects can get messy in a var block, so it's best to declare them and leave them undefined at the start of the var statement and then define them on their own later. Keeps indentation and readability more sane.

#5 @nacin
8 years ago

In 26074:

Fix order, declaration, tabbing of vars in color-picker.js.

props kadamwhite.
fixes #25877.

Note: See TracTickets for help on using tickets.