wp_notify_postauthor() does not initialize the subject and content text for custom comment types

[sebet]

Unlike wp_notify_moderator(), that uses a switch/case() statement that defaults to comment types of type 'comment', wp_notify_postauthor() uses an if/else(), resulting in $notify_message and $subject undefined var notices when these vars are concatenated later in that same function, when using a custom comment type:

Notice: Undefined variable: notify_message in ...wp-includes\pluggable.php on line 1076
Notice: Undefined variable: subject in ...\wp-includes\pluggable.php on line 1109

This can be easily fixed by initializing the vars ($var = '') or by replacing the if/else() with a switch/case() that defaults to 'comment'.

[sebet]

Small correction. I've mentioned wp_notify_moderator() two times by mistake.

Correction:

Unlike, wp_notify_moderator() that uses a switch/case() statement that defaults to comment types of type 'comment', wp_notify_postauthor() uses an if/else()...

[SergeyBiryukov]

We don't have an API for custom comment types yet (see #12668), but I guess some consistency between wp_notify_postauthor() and wp_notify_moderator() would be good.

[sebet]

Yep, consistency is good. Both functions should work in similar way.
Thanks.

[SergeyBiryukov]

In 26114:

Avoid PHP notices in wp_notify_postauthor() when using a custom comment type.
Use a switch statement for consistency with wp_notify_moderator().

fixes #25880.