WordPress.org

Make WordPress Core

#25882 closed defect (bug) (fixed)

'upgrader_process_complete' action for theme has 'plugin' type

Reported by: bamadesigner Owned by: SergeyBiryukov
Milestone: 3.8 Priority: normal
Severity: normal Version: 3.7
Component: Upgrade/Install Keywords: commit fixed-major
Focuses: Cc:

Description

I believe the 'upgrader_process_complete' action for themes has the wrong 'type' parameter in the Theme_Upgrader class in the wp-admin/includes/class-wp-upgrader.php file starting on line 980:

do_action( 'upgrader_process_complete', $this, array(
   'action' => 'update',
   'type' => 'plugin',
   'bulk' => true,
   'themes' => $themes,
   ) );

should be

do_action( 'upgrader_process_complete', $this, array(
   'action' => 'update',
   'type' => 'theme',
   'bulk' => true,
   'themes' => $themes,
   ) );

Change History (6)

comment:1 @SergeyBiryukov16 months ago

  • Milestone changed from Awaiting Review to 3.7.2
  • Version changed from trunk to 3.7

Looks like a copy/paste error in [25806].

comment:2 @SergeyBiryukov16 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 26049:

Pass correct 'type' parameter to 'upgrader_process_complete' action in Theme_Upgrader.

props bamadesigner.
fixes #25882 for trunk.

comment:3 @SergeyBiryukov16 months ago

  • Keywords commit fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:4 @ircbot14 months ago

This ticket was mentioned in IRC in #wordpress-dev by humungulous. View the logs.

comment:5 @nacin13 months ago

  • Milestone changed from 3.7.2 to 3.8

comment:6 @nacin13 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.