Opened 19 years ago
Closed 19 years ago
#2589 closed defect (bug) (fixed)
WP DB Backup core tables should reflect new and deleted tables
Reported by: |
|
Owned by: | |
---|---|---|---|
Milestone: | 2.1 | Priority: | normal |
Severity: | normal | Version: | 2.1 |
Component: | Administration | Keywords: | bg|has-patch bg|tested bg|commit bg|2nd-opinion |
Focuses: | Cc: |
Description
Add the new 'link2cat' table and delete the old 'linkcategories' table from the "These core WordPress tables will always be backed up:" list in WordPress Database Backup Plugin (wp-db-backup.php).
Attachments (3)
Change History (12)
#2
@
19 years ago
Thanks abhay, the fix works. I didn't test with Skippy's WP-Cron plugin, but notice there's a reference to tables in the wp-cron-daily function in that plugin. Should that be changed also?
#3
@
19 years ago
MichaelH: sorry I can't find the reference. Could you give me a "grep --line-number" ?
#5
@
19 years ago
- Keywords bg|needs-testing added
It's alright. I should have caught it. New patch is up.
#6
@
19 years ago
- Keywords bg|tested bg|commit added; bg|needs-testing removed
I have tested this and it works fine for me.
The cron list of tables was still missing "link2cat" so i have added that in a new patch and moved this list of tables to a class attribute storing them in an array near the top of the file so they are easy to find for updates and only in one place!
I think this is good to go for commit
#7
@
19 years ago
- Keywords bg|2nd-opinion added
While testing westi's fix on a 2.0.2 to 2.1-alpha1 upgrade, I was reminded that the linkcategories table is being left, intact, on upgrades. With this fix, that table will show in the "You may choose to include any of the following tables" column of WP DB Backup.
Any idea on what to do there, if anything?
Also, any opinion about bumping the Version from 1.7 to 1.7.something?
Good catch and easy to fix. Patch to come.