WordPress.org

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

Last modified 8 years ago

#25897 closed defect (bug) (fixed)

Twenty Fourteen: allow slider "Previous" and "Next" labels to be translated

Reported by: lancewillett Owned by: lancewillett
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-patch
Focuses: Cc:

Description

See // Text labels: @todo allow translation in slider.js file line 549. These should be i18n-ized.

Attachments (1)

25897.diff (2.0 KB) - added by micahwave 8 years ago.

Download all attachments as: .zip

Change History (4)

@micahwave
8 years ago

#1 @micahwave
8 years ago

I localized the slider script with next and previous text values that can be translated.

#2 @lancewillett
8 years ago

  • Owner set to lancewillett
  • Resolution set to fixed
  • Status changed from new to closed

In 26071:

Twenty Fourteen: allow slider "Previous" and "Next" labels to be translated, props michahwave. Fixes #25897.

#3 @lancewillett
8 years ago

Patch looks great, thanks micahwave! Only things I changed was remove the "todo" bit and time() to today's date. It doesn't need to be dynamic, we just change it when the file version needs to be bumped (doing it manually is fine).

Note: See TracTickets for help on using tickets.