WordPress.org
Get WordPress

Make WordPress Core

Opened 10 years ago

Closed 10 years ago

Last modified 10 years ago

#25912 closed defect (bug) (fixed)

jshint shouldn't throw errors - wp-admin/js/common.js

Reported by: jorbin's profile jorbin Owned by: nacin's profile nacin
Milestone: 3.8 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords: has-patch
Focuses: Cc:

Description


Attachments (5)

common.global.diff​ (437 bytes) - added by jorbin 10 years ago.
common.semicolon.diff​ (718 bytes) - added by jorbin 10 years ago.
common.vars.diff​ (2.2 KB) - added by jorbin 10 years ago.
common.eqeqeq.diff​ (1.2 KB) - added by jorbin 10 years ago.
commmon.all.diff​ (4.2 KB) - added by jorbin 10 years ago.

Download all attachments as: .zip

Change History (9)

@jorbin
10 years ago

@jorbin
10 years ago

@jorbin
10 years ago

@jorbin
10 years ago

@jorbin
10 years ago

#1 @jorbin
10 years ago

the === checks aren't risky here (and are thrown even with eqeqeq being false)

all.diff contains everything in one easy package.

#2 @jorbin
10 years ago

  • Keywords has-patch added

#3 @nacin
10 years ago

  • Owner set to nacin
  • Resolution set to fixed
  • Status changed from new to closed

In 26112:

Free common.js of JSHint errors.

props jorbin.
fixes #25912.

#4 @nacin
10 years ago

In 26208:

Residual JSHint fixes in common.js and edit-comments.js.

see #25912, #25979.

Note: See TracTickets for help on using tickets.